From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gCSRz-0007oH-Ue for guix-patches@gnu.org; Tue, 16 Oct 2018 12:44:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gCSRv-0006ov-Q4 for guix-patches@gnu.org; Tue, 16 Oct 2018 12:44:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49620) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gCSRt-0006m8-Uf for guix-patches@gnu.org; Tue, 16 Oct 2018 12:44:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gCSRt-0003oF-Lp for guix-patches@gnu.org; Tue, 16 Oct 2018 12:44:01 -0400 Subject: [bug#33042] [PATCH] gnu: Add soundconverter. Resent-Message-ID: Date: Tue, 16 Oct 2018 12:43:27 -0400 From: Leo Famulari Message-ID: <20181016164327.GC25057@jasmine.lan> References: <20181014201810.619-1-mail@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZmUaFz6apKcXQszQ" Content-Disposition: inline In-Reply-To: <20181014201810.619-1-mail@cbaines.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 33042@debbugs.gnu.org --ZmUaFz6apKcXQszQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Oct 14, 2018 at 09:18:10PM +0100, Christopher Baines wrote: > * gnu/packages/gnome.scm (soundconverter): New variable. Thanks, it's nice to have graphical programs for this sort of task :) > + (patches > + (list > + (origin > + (method url-fetch) > + (uri (string-append > + "https://salsa.debian.org/multimedia-team/soundconverter" > + "/raw/master/debian/patches/" > + "0002-Only-fetch-profiles-if-GConf-is-still-available.patch")) > + (sha256 > + (base32 > + "00nxpbkz7ihzrbz91ms7bd2mjgyhkbxpaa8zxj4xnkv4pjmg61hh"))))))) I think it's better if we include this file in our source code, since it's not very big and Debian's code infrastructure URLs seem to change every few years. Also, the URL is not versioned, so maybe the patch would change in the future. > + (add-after 'unpack 'fix-POTFILES.in > + (lambda _ > + (substitute* "po/POTFILES.in" > + (("soundconverter/gconfstore\\.py") "")))) Please add an explanatory comment for this. > + (add-after 'install 'wrap-rhythmbox > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out")) > + (python-path (getenv "PYTHONPATH")) > + (gi-typelib-path (getenv "GI_TYPELIB_PATH")) > + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))) > + (wrap-program (string-append out "/bin/soundconverter") > + `("PYTHONPATH" ":" prefix (,python-path)) > + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)) > + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))) > + #t))))) If possible, I think it's better to use the python-build-system's wrap phase for PYTHONPATH. The hplip package has an example. > + (synopsis "Audio file converter for the GNOME Desktop") It works in i3, too :) --ZmUaFz6apKcXQszQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlvGFS8ACgkQJkb6MLrK fwjrCw/+Oewa7FHBGiKK687mke+YoZwbTrpp2sOCIvKe1E0SGliHfp27gmPpn7Ev xFyHgyL/g10XAEgSCYdwA310/bkTf9qplZmVhuTuUXBU7d8+Mu39L4hD+UsTzivW AVd/WrnyMUZh7pgJOKJAwJdi9YfZULv3f9t9KmC1HoWiAzCHCGmZSDtXkpyXO/kv KiDBPbA+hqj4O7GjOhVtmDyOfTphiuMCEeZjnIpo538m0C5EycY172jPb9Kus9fY Jjeslgal9cMbKEeBud7EWGkm6F93RyQKIXKL6bAEeGcIpTM1C5Zj3tP1FDHU+WnE xfEVb9S5r3HvhxbscNI5DE3LWaJ1478iRj1UIJTrEEPOniDmOLt//453oHX/qfJ0 1eDTBR6YEdCV1qYn/5HvfZp2dmALbUwfKjTeFlzsTMQ6jCV9J0f7+tRV1uqWMC5z dk4Graknh7i24aPJbkUw5toJE1SAgxaQf8cJwFlNxZUsM08n0xKr1U5O+jvi2uD8 Wom37eTMsS/UezbPZcEzuEJaCQ/tw5qSZdDZOKAwpvJqNdf6KVZQHBVuaJbQBl1h 7iYVZvCOVRHLiqrlIdVod2+H/Yaq8RrqmrRiiGUwQoAz+u2XDvSm87OK8MPPXmUr aF8HYoJlAxifAwkMnF73aJu95u1vHePGw0rm3JuPeArXOM+f7XQ= =SMoI -----END PGP SIGNATURE----- --ZmUaFz6apKcXQszQ--