From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Patterson Subject: bug#32770: Packaging SLIME/SWANK as Common Lisp library Date: Sat, 29 Sep 2018 15:16:30 -0400 Message-ID: <20180929151630.00cf6396@mailservices.uwaterloo.ca> References: <87museeyy5.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6Kji-0005m1-Bh for bug-guix@gnu.org; Sat, 29 Sep 2018 15:17:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6Kje-0001Qe-D0 for bug-guix@gnu.org; Sat, 29 Sep 2018 15:17:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54896) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6Kje-0001QW-85 for bug-guix@gnu.org; Sat, 29 Sep 2018 15:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g6Kjd-00074Q-RU for bug-guix@gnu.org; Sat, 29 Sep 2018 15:17:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87museeyy5.fsf@ambrevar.xyz> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Pierre Neidhardt Cc: 32770@debbugs.gnu.org Hey Pierre, Sorry for taking so long to get back to you. On Wed, 19 Sep 2018 09:19:46 +0200 Pierre Neidhardt wrote: > On the long road to packaging Next browser (bug #32729), I've hit a > big obstacle: packaging the SLIME/SWANK dependency. >=20 > We currently have an emacs-slime package, but that cannot be used as a > Common Lisp dependency. >=20 I've managed to figure out why that is. With the branch you're using for the package, the asd file defines the package and variables that get used - but in guix that asd file gets discarded. I think the right way is to have those definitions defined in a separate file, and actually they are defined in one as well. The following patch adds that file to the asd and makes sure it compiles successfully. I've noticed that the pull request that branch was made for is closed though - I'll try to see if I can get things building with the other one that's open and maybe co-ordinate with upstream to get that in. For now though, maybe this will unblock you. The patch was made after rebasing your branch unto master. I was also able to drop the commit named "build-system/asdf: Fix normalize-string to support versioned dependencies", since there's a more general version of it in master now. -- Andy =46rom a7b945bb58f22ac6c0bcee1bee62e40ffa9873a6 Mon Sep 17 00:00:00 2001 From: Andy Patterson Date: Sat, 29 Sep 2018 15:04:40 -0400 Subject: [PATCH] gnu: slime-swank: Make it loadable. * gnu/packages/lisp.scm (sbcl-slime-swank)[origin]: Add (guix build utils). : Patch the asd file to load swank-loader-asdf. --- gnu/packages/lisp.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm index aa146c9a5..a05d95f60 100644 --- a/gnu/packages/lisp.scm +++ b/gnu/packages/lisp.scm @@ -2223,12 +2223,18 @@ writing code that contains string literals that contain code themselves.") (base32 ;; "065bc4y6iskazdfwlhgcjlzg9bi2hyjbhmyjw3461506pgkj08vi" "0pkmg94wn4ii1zhlrncn44mdc5i6c5v0i9gbldx4dwl2yy7ibz5c")) + (modules '((guix build utils))) (snippet '(begin (substitute* "contrib/swank-listener-hooks.lisp" ((":compile-toplevel :load-toplevel ") "")) (substitute* "contrib/swank-presentations.lisp" ((":compile-toplevel :load-toplevel ") "")) + (substitute* "swank.asd" + ((":file \"packages\".*" all) + (string-append all "(:file \"swank-loader-asdf\")\n"))) + (substitute* "swank-loader-asdf.lisp" + ((":common-lisp" all) (string-append all " #:asdf"))) #t)))) (build-system asdf-build-system/sbcl) (arguments --=20 2.19.0