bug#32836: emacs-magit is broken (and probably others) due to package renaming

bug#32836: emacs-magit is broken (and probably others) due to package renaming

[Björn Höfling]

[-- Attachment #1: Type: text/plain, Size: 960 bytes --]

Commit

5c8031ff7382ec9079040d08ae5a05b4dd2352b7

mass-renamed emacs-packages from "foo" to "emacs-foo". Unfortunately,
some package definitions use the package-name for building the URL.
That is for example the case in emacs-magit:

(define-public emacs-magit
  (package
    (name "emacs-magit")
    (version "2.13.0")
    (source (origin
             (method url-fetch)
             (uri (string-append
                   "https://github.com/magit/magit/releases/download/"
                   version "/" name "-" version ".tar.gz"))

Thus, it can no longer be built:

Starting download of /gnu/store/h01ag9sr8nxiqbnlblmxplnv43a2005j-emacs-magit-2.13.0.tar.gz
From https://github.com/magit/magit/releases/download/2.13.0/emacs-magit-2.13.0.tar.gz...
ERROR: download failed "https://github.com/magit/magit/releases/download/2.13.0/emacs-magit-2.13.0.tar.gz" 404 "Not Found"

Pierre, could you have a look into it?

Thanks

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

bug#32836: emacs-magit is broken (and probably others) due to package renaming

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

Oopsy, missed that indeed! xD
Sorry for the trouble, will fix as soon as possible.

By the way, I think using "name" for URLs is a bad practice, we only need
"version" there.  What do you people think?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#32836: emacs-magit is broken (and probably others) due to package renaming

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

OK, I'll add this recommendation to the Guix packaging tutorial.

I've pushed the fix upstream.  Only magit and groovy-modes were affected.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#32836: emacs-magit is broken (and probably others) due to package renaming

[Taylan Kammer]

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> Oopsy, missed that indeed! xD
> Sorry for the trouble, will fix as soon as possible.
>
> By the way, I think using "name" for URLs is a bad practice, we only need
> "version" there.  What do you people think?

I agree.  Whenever I've seen 'name' being used in URL definitions in the
past I wondered what the point is, since our naming doesn't necessarily
align with the name of the file to be downloaded.

Taylan

bug#32836: emacs-magit is broken (and probably others) due to package renaming

[Alex Kost]

Pierre Neidhardt (2018-09-25 17:04 +0200) wrote:

> Oopsy, missed that indeed! xD
> Sorry for the trouble, will fix as soon as possible.
>
> By the way, I think using "name" for URLs is a bad practice, we only need
> "version" there.  What do you people think?

I totally agree!  I don't like this practice very much.

-- 
Alex

bug#32836: emacs-magit is broken (and probably others) due to package renaming

[Ludovic Courtès]

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> OK, I'll add this recommendation to the Guix packaging tutorial.

Sounds good.

> I've pushed the fix upstream.  Only magit and groovy-modes were affected.

Thanks for the quick fix!

Ludo’.

bug#32836: emacs-magit is broken (and probably others) due to package renaming

[Nils Gillmann]

Alex Kost transcribed 331 bytes:
> Pierre Neidhardt (2018-09-25 17:04 +0200) wrote:
> 
> > Oopsy, missed that indeed! xD
> > Sorry for the trouble, will fix as soon as possible.
> >
> > By the way, I think using "name" for URLs is a bad practice, we only need
> > "version" there.  What do you people think?
> 
> I totally agree!  I don't like this practice very much.
> 
> -- 
> Alex
> 
> 
> 

Very often the name we use, except for language specific packages, is the same
as upstream uses. "name" can be shorter than "whatever-long-name".

bug#32836: emacs-magit is broken (and probably others) due to package renaming

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]


> Very often the name we use, except for language specific packages, is the same
> as upstream uses. "name" can be shorter than "whatever-long-name".

It often works, but at the cost of raising issues like this thread.
I think it's more important to make the URL reliable than to make it short :)

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#32836: emacs-magit is broken (and probably others) due to package renaming

[Björn Höfling]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

On Tue, 25 Sep 2018 19:58:04 +0200
Pierre Neidhardt <mail@ambrevar.xyz> wrote:

> OK, I'll add this recommendation to the Guix packaging tutorial.
> 
> I've pushed the fix upstream.  Only magit and groovy-modes were
> affected.
> 

Looks good. Thanks for fixing!

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]