From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4qmj-0008KC-Pn for guix-patches@gnu.org; Tue, 25 Sep 2018 13:06:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4qmg-0001K3-8A for guix-patches@gnu.org; Tue, 25 Sep 2018 13:06:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49708) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g4qmg-0001Jj-3k for guix-patches@gnu.org; Tue, 25 Sep 2018 13:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g4qmf-0005Xu-Ti for guix-patches@gnu.org; Tue, 25 Sep 2018 13:06:01 -0400 Subject: [bug#32813] [PATCH 1/4] gnu: Add tegola. Resent-Message-ID: Date: Tue, 25 Sep 2018 19:04:59 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20180925190459.2f029298@alma-ubu> In-Reply-To: <20180923204311.8086-1-julien@lepiller.eu> References: <20180923223952.7168c8e8@lepiller.eu> <20180923204311.8086-1-julien@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/qy0G.5N6K1I44ureowljA.."; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 32813@debbugs.gnu.org --Sig_/qy0G.5N6K1I44ureowljA.. Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 23 Sep 2018 22:43:08 +0200 Julien Lepiller wrote: > * gnu/packages/geo.scm (tegola): New variable. > --- > gnu/packages/geo.scm | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) >=20 > diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm > index ae6ba024e..e6aafff7d 100644 > --- a/gnu/packages/geo.scm > +++ b/gnu/packages/geo.scm > @@ -760,3 +760,33 @@ location queries to be run in SQL.") > license:bsd-3 ; files only say "BSD" > ;; doc > license:cc-by-sa3.0)))) > + > +(define-public tegola > + (package > + (name "tegola") > + (version "0.7.0") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/go-spatial/tegola/archive/v" > + version ".tar.gz")) > + (sha256 > + (base32 > + > "09vnzxfn0r70kmd776kcdfqxhzdj11syxa0b27z4ci1k367v7viw")))) > + (build-system go-build-system) > + (arguments > + `(#:import-path "github.com/go-spatial/tegola/cmd/tegola" > + #:unpack-path "github.com/go-spatial" > + #:phases > + (modify-phases %standard-phases > + (add-before 'build 'rename-import > + (lambda _ > + (rename-file (string-append > "src/github.com/go-spatial/tegola-" ,version) > + "src/github.com/go-spatial/tegola") > + #t))))) > + (home-page "http://tegola.io") > + (synopsis "Vector tile server for maps") > + (description "Tegola is a free vector tile server written in > Go. Tegola +takes geospatial data and slices it into vector tiles > that can be efficiently +delivered to any client.") > + (license license:expat))) Hi Julien, thanks for the patch-set! Here are my remarks: Import for go-system missing: + #:use-module (guix build-system go) ./pre-inst-env guix lint $REVIEW_PACKAGE gnu/packages/geo.scm:770:12: tegola@0.7.0: the source file name should cont= ain the package name --> i.e. add to the source a line: (file-name (string-append name "-" version ".zip")) Under directory 'vendor' are a bunch of dependencies. I never used Go, so I ask carefully: * Do we already have them as a package (or some of them)? * Can those be snipped away? * If not, please check the licenses. With licensecheck, I found at least: Apache 2.0 BSD-2 BSD-3 And here is one I didn't know yet and I think we don't yet have a license term for it in Guix :-) vendor/github.com/BurntSushi/toml/COPYING DO WHAT THE FUCK YOU WANT TO PUBLIC LICENSE Isn't that nice? :-) I ran the program and got: ./pre-inst-env guix environment --ad-hoc tegola -- tegola version version not set But I wouldn't invest too much time into this one, as long as the "serve" command works (havn't tried that). Thanks, Bj=C3=B6rn --Sig_/qy0G.5N6K1I44ureowljA.. Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAluqarwACgkQvyhstlk+X/3G6gCfbwLHq9Oiu3IUcfSfONKd81Yi T50AnjWDyxlEl0lxN22Ivo4C+7eVtrhZ =kJMG -----END PGP SIGNATURE----- --Sig_/qy0G.5N6K1I44ureowljA..--