all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nils Gillmann <ng0@n0.is>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 32634@debbugs.gnu.org
Subject: [bug#32634] RFC: Process build output
Date: Sat, 8 Sep 2018 16:11:44 +0000	[thread overview]
Message-ID: <20180908161143.aonygx4iqnj2zury@abyayala> (raw)
In-Reply-To: <877ek1z3gg.fsf@elephly.net>

Hi,

Ricardo Wurmus transcribed 2.1K bytes:
> Hi Guix,
> 
> this patch set is a first draft to stylize (potentially confusing) build
> output when using “guix package” and “guix build”.
> 
> This is done by adding a soft port that matches on lines in the build
> output and colorizes them (unless INSIDE_EMACS or NO_COLOR are set, or
> when output is redirected).  For “guix package” the default behaviour is

So far I have one comment:

Would it make sense to use 'GUIX_UI_NO_COLOR' instead? This makes it
clear what it is for (use clear function names), and it does not
impose using "no colors" in other terminal applications if you
permanently export it.

> to also hide all build output that does not announce progress (unless
> “--verbose” is passed) and to let a spinner show progress instead.  For
> “guix build” all build output is still printed.
> 
> Honestly, I’m not really happy with the results, but I think it’s enough
> to start a discussion about where this should lead.
> 
> One thing I don’t like is that I had to set the “print-build-trace?”
> default option to be able to display what build is currently happening.
> Unfortunately, for small derivations this leads to output like this:
> 
> --8<---------------cut here---------------start------------->8---
> Building /gnu/store/2x5xmvimja0pbkvvr8rym91q0249ajiv-fonts-dir.drv - x86_64-linux
> Built /gnu/store/2x5xmvimja0pbkvvr8rym91q0249ajiv-fonts-dir.drv
> Building /gnu/store/diz3pmgrqibvp2pyvgh4wyr4nx5vlx0y-glib-schemas.drv - x86_64-linux
> Built /gnu/store/diz3pmgrqibvp2pyvgh4wyr4nx5vlx0y-glib-schemas.drv
> Building /gnu/store/ss70j6lf8xxiiykdys92iw92khx68ix9-info-dir.drv - x86_64-linux
> Built /gnu/store/ss70j6lf8xxiiykdys92iw92khx68ix9-info-dir.drv
> Building /gnu/store/rh92rslbj4x9abyna6lc11jqifbavx13-librsvg-2.40.20.drv - x86_64-linux
> Built /gnu/store/rh92rslbj4x9abyna6lc11jqifbavx13-librsvg-2.40.20.drv
> --8<---------------cut here---------------end--------------->8---
> 
> I would prefer:
> 
>     Building /gnu/store/rh92rslbj4x9abyna6lc11jqifbavx13-librsvg-2.40.20.drv … DONE
> 
> or similar.
> 
> I don’t know about whether the colours are any good; I think the bold
> green is hard to read on a bright terminal, while the black is hard to
> read on a dark terminal.
> 
> Lastly: the spinner.  It’s a bit boring, I think.
> 
> What do you think?  Is this a step in the right direction?
> 
> --
> Ricardo
> 
> 
> 
> 

  parent reply	other threads:[~2018-09-08 16:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 15:29 [bug#32634] RFC: Process build output Ricardo Wurmus
2018-09-04 15:32 ` [bug#32634] [PATCH 1/2] ui: Add support for colorization Ricardo Wurmus
2018-09-04 15:32   ` [bug#32634] [PATCH 2/2] ui: Add soft port for styling and filtering build output Ricardo Wurmus
2018-09-08  9:49     ` Danny Milosavljevic
2018-09-09 21:22       ` bug#32634: " Ricardo Wurmus
2018-09-10 13:17     ` [bug#32634] " Ludovic Courtès
2018-09-10 14:28       ` Ludovic Courtès
2018-09-08  8:32   ` [bug#32634] [PATCH 1/2] ui: Add support for colorization Danny Milosavljevic
2018-09-08 16:11 ` Nils Gillmann [this message]
2018-09-08 16:58   ` [bug#32634] RFC: Process build output Tobias Geerinckx-Rice
2018-09-08 17:03   ` Tobias Geerinckx-Rice
2018-09-09 12:32 ` Danny Milosavljevic
2018-09-09 16:26   ` Ricardo Wurmus
2018-09-10 14:39 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180908161143.aonygx4iqnj2zury@abyayala \
    --to=ng0@n0.is \
    --cc=32634@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.