all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#32391] [PATCH] gnu: Add VBinDiff.
@ 2018-08-07 22:36 Leo Famulari
  2018-08-09  5:01 ` Danny Milosavljevic
  0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2018-08-07 22:36 UTC (permalink / raw)
  To: 32391

I'm not sure which module to put this in!

* gnu/packages/patchutils.scm (vbindiff): New variable.
---
 gnu/packages/patchutils.scm | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/patchutils.scm b/gnu/packages/patchutils.scm
index 224b0e8d6..55f4fd510 100644
--- a/gnu/packages/patchutils.scm
+++ b/gnu/packages/patchutils.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
-;;; Copyright © 2015 Leo Famulari <leo@famulari.name>
+;;; Copyright © 2015, 2018 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -32,9 +32,10 @@
   #:use-module (gnu packages file)
   #:use-module (gnu packages gawk)
   #:use-module (gnu packages less)
+  #:use-module (gnu packages mail)
+  #:use-module (gnu packages ncurses)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages python)
-  #:use-module (gnu packages mail)
   #:use-module (gnu packages xml))
 
 (define-public patchutils
@@ -209,3 +210,24 @@ list, and commands that can search that database.  It allows users to track
 the status of a patch, apply patches, and search for patches---all that from
 the command-line or from Emacs via its Notmuch integration.")
       (license gpl2+))))
+
+(define-public vbindiff
+  (package
+    (name "vbindiff")
+    (version "3.0_beta5")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://www.cjmweb.net/vbindiff/vbindiff-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1f1kj4jki08bnrwpzi663mjfkrx4wnfpzdfwd2qgijlkx5ysjkgh"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (home-page "https://www.cjmweb.net/vbindiff/")
+    (synopsis "Console-based tool for comparing binary data")
+    (description "Visual Binary Diff (VBinDiff) displays files in hexadecimal
+and ASCII (or EBCDIC).  It can also display two files at once, and highlight the
+differences between them.  It works well with large files (up to 4 GiB).")
+    (license gpl2+)))
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#32391] [PATCH] gnu: Add VBinDiff.
  2018-08-07 22:36 [bug#32391] [PATCH] gnu: Add VBinDiff Leo Famulari
@ 2018-08-09  5:01 ` Danny Milosavljevic
  2018-08-09 12:07   ` bug#32391: " Leo Famulari
  0 siblings, 1 reply; 3+ messages in thread
From: Danny Milosavljevic @ 2018-08-09  5:01 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 32391

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

Hi Leo,

On Tue,  7 Aug 2018 18:36:31 -0400
Leo Famulari <leo@famulari.name> wrote:

> I'm not sure which module to put this in!

> +++ b/gnu/packages/patchutils.scm

Sounds good, as long as we don't introduce harmful module cycles.

> +    (description "Visual Binary Diff (VBinDiff) displays files in hexadecimal
> +and ASCII (or EBCDIC).  It can also display two files at once, and highlight the
> +differences between them.  It works well with large files (up to 4 GiB).")

Maybe mention the command (@command{vbindiff}) ?

Otherwise LGTM!

I also tested it--kinda reminds me of the hex editors of old :)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#32391: [PATCH] gnu: Add VBinDiff.
  2018-08-09  5:01 ` Danny Milosavljevic
@ 2018-08-09 12:07   ` Leo Famulari
  0 siblings, 0 replies; 3+ messages in thread
From: Leo Famulari @ 2018-08-09 12:07 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 32391-done

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

On Thu, Aug 09, 2018 at 07:01:35AM +0200, Danny Milosavljevic wrote:
> Maybe mention the command (@command{vbindiff}) ?

Okay!

> Otherwise LGTM!

Thanks for the review!

> I also tested it--kinda reminds me of the hex editors of old :)

Nostalgic and useful :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-09 12:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-07 22:36 [bug#32391] [PATCH] gnu: Add VBinDiff Leo Famulari
2018-08-09  5:01 ` Danny Milosavljevic
2018-08-09 12:07   ` bug#32391: " Leo Famulari

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.