all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#32386] [PATCH] gnu: Add ubridge.
@ 2018-08-07  8:38 Oleg Pykhalov
  2018-08-07 20:58 ` Leo Famulari
  0 siblings, 1 reply; 3+ messages in thread
From: Oleg Pykhalov @ 2018-08-07  8:38 UTC (permalink / raw)
  To: 32386

* gnu/packages/networking.scm (ubridge): New variable.
---
 gnu/packages/networking.scm | 40 +++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 5055f030a..a8c5a7aee 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2042,3 +2042,43 @@ SNMP v3 using both IPv4 and IPv6.")
                    (license:non-copyleft
                     "http://www.net-snmp.org/about/license.html"
                     "CMU/UCD copyright notice")))))
+
+(define-public ubridge
+  (package
+    (name "ubridge")
+    (version "0.9.14")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/GNS3/ubridge/archive/v"
+                                  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1hivb8wqkk5047bdl2vbsbcvkmam1107hx1ahy4virq2bkqki1fj"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ;no tests
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         (add-before 'build 'set-env-cc
+           (lambda _
+             (setenv "CC" "gcc")
+           #t))
+         (add-before 'install 'set-bindir
+           (lambda* (#:key  inputs outputs #:allow-other-keys)
+             (let ((bin (string-append (assoc-ref outputs "out")
+                                       "/bin")))
+               (mkdir-p bin)
+               (substitute* "Makefile"
+                 (("\\$\\(BINDIR\\)") bin)
+                 (("\tsetcap cap_net.*$") "")))
+             #t)))))
+    (inputs
+     `(("libpcap" ,libpcap)))
+    (home-page "https://github.com/GNS3/ubridge/")
+    (synopsis "Bridge for UDP tunnels, Ethernet, TAP and VMnet interfaces")
+    (description "uBridge is a simple program to create user-land bridges
+between various technologies.  Currently bridging between UDP tunnels,
+Ethernet and TAP interfaces is supported.  Packet capture is also supported.")
+    (license license:gpl3+)))
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#32386] [PATCH] gnu: Add ubridge.
  2018-08-07  8:38 [bug#32386] [PATCH] gnu: Add ubridge Oleg Pykhalov
@ 2018-08-07 20:58 ` Leo Famulari
  2018-08-07 23:50   ` bug#32386: " Oleg Pykhalov
  0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2018-08-07 20:58 UTC (permalink / raw)
  To: Oleg Pykhalov; +Cc: 32386

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

On Tue, Aug 07, 2018 at 11:38:10AM +0300, Oleg Pykhalov wrote:
> * gnu/packages/networking.scm (ubridge): New variable.
> +         (add-before 'build 'set-env-cc
> +           (lambda _
> +             (setenv "CC" "gcc")
> +           #t))

Would it work to set this in #:make-flags? I think that's a little
clearer.

> +    (description "uBridge is a simple program to create user-land bridges
> +between various technologies.  Currently bridging between UDP tunnels,
> +Ethernet and TAP interfaces is supported.  Packet capture is also supported.")

Please add a comma in the second sentence: "Currently, bridging between
UDP tunnels, Ethernet, and TAP interfaces is supported."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#32386: [PATCH] gnu: Add ubridge.
  2018-08-07 20:58 ` Leo Famulari
@ 2018-08-07 23:50   ` Oleg Pykhalov
  0 siblings, 0 replies; 3+ messages in thread
From: Oleg Pykhalov @ 2018-08-07 23:50 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 32386-done

[-- Attachment #1: Type: text/plain, Size: 938 bytes --]

Hello Leo,

Thank you for review.

Leo Famulari <leo@famulari.name> writes:

> On Tue, Aug 07, 2018 at 11:38:10AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/networking.scm (ubridge): New variable.
>> +         (add-before 'build 'set-env-cc
>> +           (lambda _
>> +             (setenv "CC" "gcc")
>> +           #t))
>
> Would it work to set this in #:make-flags? I think that's a little
> clearer.

Indeed, I forgot about ‘#:make-flags’, thank you.

>> +    (description "uBridge is a simple program to create user-land bridges
>> +between various technologies.  Currently bridging between UDP tunnels,
>> +Ethernet and TAP interfaces is supported.  Packet capture is also supported.")
>
> Please add a comma in the second sentence: "Currently, bridging between
> UDP tunnels, Ethernet, and TAP interfaces is supported."

OK.

Pushed as 277f25ce5af060e2a057f5f43eeea2ae6f4fc5b9

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-08  2:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-07  8:38 [bug#32386] [PATCH] gnu: Add ubridge Oleg Pykhalov
2018-08-07 20:58 ` Leo Famulari
2018-08-07 23:50   ` bug#32386: " Oleg Pykhalov

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.