From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: bug#32300: [PATCH] database: Fix the builds limit issue. Date: Tue, 7 Aug 2018 12:46:26 +0200 Message-ID: <20180807124626.29e6a12a@scratchpost.org> References: <874lgjc5g9.fsf@lassieur.org> <20180804160057.20254-1-clement@lassieur.org> <87sh3ui038.fsf@lassieur.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/ixemy96i5NFfRSBps0z_6wc"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmzW6-0007tW-3a for bug-guix@gnu.org; Tue, 07 Aug 2018 06:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmzW2-0001rg-To for bug-guix@gnu.org; Tue, 07 Aug 2018 06:47:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38173) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fmzW2-0001ra-Pv for bug-guix@gnu.org; Tue, 07 Aug 2018 06:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fmzW2-0007MC-Gb for bug-guix@gnu.org; Tue, 07 Aug 2018 06:47:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87sh3ui038.fsf@lassieur.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 32300@debbugs.gnu.org --Sig_/ixemy96i5NFfRSBps0z_6wc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Cl=C3=A9ment, On Sat, 04 Aug 2018 18:10:51 +0200 Cl=C3=A9ment Lassieur wrote: > Cl=C3=A9ment Lassieur writes: >=20 > > Fixes . > > > > * src/cuirass/database.scm (filters->order): New procedure. > > (db-get-builds): Remove FORMAT-OUTPUT, CONS-OUTPUT, COLLECT-OUTPUTS, > > FINISH-GROUP, SAME-GROUP?, GROUP-OUTPUTS procedures. Remove the 'LEFT = JOIN > > Outputs' clause. Use DB-GET-OUTPUTS for each build that was fetched. = =20 >=20 > This may be less efficient because there are more SQL queries (one per > output), but it's way less complicated and less buggy, so I think it's > worth it. The more complicated version is a LOT faster - and was added because the version in this patch was just way too slow (unusably slow). I think it's better to also remove the call to db-get-outputs (and the entry #:outputs) entirely. I don't think our overview page even shows the outputs in the first place, so why fetch them? --Sig_/ixemy96i5NFfRSBps0z_6wc Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAltpeIMACgkQ5xo1VCww uqUjkwf+Lh7+SmRc8RZ0LvbpPoX2Grun4UCj/RAqv0DruNFSuDh+ukz+uU+gBfsA DTX0nSKyrNDm5ECAOUrmePx1GkP+joGYsvzzor5Txz+keP1KATnv0MKqZl+NbTyy pC6OpWc4i/F42L03O8yuOQsOel9iRO4jZF/+reO1vIVcMOZW8jnTUxpApouzkTAf BleQ/U/YMibzpFONSX7/OxVuRoJcjj+qSSduIS1J1BEddPJ+GlgML8pPDqUBEALi aFtt3xSe6vDnN1KiHJQxeS7qiGgZTNDbSTTCLeGa/0qm9AkrJS+3a9qFBbdFjEo5 6ksXjeQyShBrxysdAURU1rD0EhvYpA== =ibYz -----END PGP SIGNATURE----- --Sig_/ixemy96i5NFfRSBps0z_6wc--