From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmnzu-0006QR-Bz for guix-patches@gnu.org; Mon, 06 Aug 2018 18:29:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmnzr-0007jJ-6A for guix-patches@gnu.org; Mon, 06 Aug 2018 18:29:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:37955) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fmnzq-0007id-Ml for guix-patches@gnu.org; Mon, 06 Aug 2018 18:29:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fmnzq-0004Rk-Ai for guix-patches@gnu.org; Mon, 06 Aug 2018 18:29:02 -0400 Subject: [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby. Resent-Message-ID: Date: Tue, 7 Aug 2018 00:28:40 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20180807002840.5df9b494@alma-ubu> In-Reply-To: <20180805144322.4705-1-mail@cbaines.net> References: <871sbczxm8.fsf@cbaines.net> <20180805144322.4705-1-mail@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/XdQq9oE5H+IN0JlMN9a9zKX"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 32370@debbugs.gnu.org --Sig_/XdQq9oE5H+IN0JlMN9a9zKX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 5 Aug 2018 15:43:19 +0100 Christopher Baines wrote: > From: Ben Woodcroft >=20 > * gnu/packages/ruby.scm (ruby-yajl-ruby): New variable. >=20 > Signed-off-by: Christopher Baines > --- > gnu/packages/ruby.scm | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) >=20 > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > index 908dfd575..a06be3e26 100644 > --- a/gnu/packages/ruby.scm > +++ b/gnu/packages/ruby.scm > @@ -3626,6 +3626,39 @@ features such as filtering and fine grained > logging.") (home-page > "https://github.com/pjotrp/bioruby-logger-plugin") (license > license:expat)))=20 > +(define-public ruby-yajl-ruby > + (package > + (name "ruby-yajl-ruby") > + (version "1.4.0") 1.4.1 is availabe. Do we have a specific reason for 1.4.0? Either update or explain in a comment (Well, that would be at least my comment for a 'normal' package. I'm unsure how to handle this one right: It's part of the Rails-branch and I noticed there are some outdated packages. They could be outdated just because Ben started in 2016 with that (and still, there is no Rails in Guix) or there could be a specific reason for that (i.e Rails or a sub-dependency needs exactly this version). Or we just say: hey, let's just get these patches in as they were in 2016 to no longer prolonge this. We can update later). License: ./ext/yajl/yajl_encode.h: BSD (3 clause) ./ext/yajl/yajl_ext.c: MIT/X11 (BSD like) ./ext/yajl/yajl_ext.h: MIT/X11 (BSD like) ./ext/yajl/yajl_gen.c: BSD (3 clause) We already have yajl. Is it possible to use that instead of the "ext" path? Does that make sense? Should we at least add a TODO-Comment? name: libyajl version: 2.1.0 outputs: out systems: x86_64-linux i686-linux armhf-linux aarch64-linux mips64el-linux dependencies:=20 location: gnu/packages/web.scm:750:2 homepage: https://lloyd.github.io/yajl/ license: ISC synopsis: C library for parsing JSON =20 description: Yet Another JSON Library (YAJL) is a small event-driven + (SAX-style) JSON parser written in ANSI C and a small validating JSON + generator. relevance: 6 BTW, libyajl changed license to ISC on April 20, 2011: https://github.com/lloyd/yajl/commit/de81b1fcd22b29b152f921f23faab759c79da7= e1#diff-7116ef0705885343c9e1b2171a06be0e When I add --check -K --no-grafts, it says it is not deterministic. But: diffoscope /gnu/store/88dhpv16b5l55xf4dh090a6n93sh2akn-ruby-yajl-ruby-1.4.0= /gnu/store/88dhpv16b5l55xf4dh090a6n93sh2akn-ruby-yajl-ruby-1.4.0-check | less is empty. Is this a general Ruby problem? I checked that randomly with ruby-unf-ext-0.0.7.1 but that is deterministic. Hm. Bj=C3=B6rn --Sig_/XdQq9oE5H+IN0JlMN9a9zKX Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAltoy5kACgkQvyhstlk+X/2DnwCgphC6gr1IXP436p6iqb5Gt+vS bWgAn1sd1SXe1ME190O1NYjYO8/s2TSU =uVSC -----END PGP SIGNATURE----- --Sig_/XdQq9oE5H+IN0JlMN9a9zKX--