From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmPh7-000415-JX for guix-patches@gnu.org; Sun, 05 Aug 2018 16:32:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmPh4-00011r-Fr for guix-patches@gnu.org; Sun, 05 Aug 2018 16:32:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:37058) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fmPh4-00010y-BG for guix-patches@gnu.org; Sun, 05 Aug 2018 16:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fmPh3-0004oz-Rx for guix-patches@gnu.org; Sun, 05 Aug 2018 16:32:01 -0400 Subject: [bug#28004] Chromium Resent-Message-ID: Date: Sun, 5 Aug 2018 20:32:22 +0000 From: ng0 Message-ID: <20180805203222.iyvpw5wansinz6tb@abyayala> References: <87muzvv7ku.fsf@fastmail.com> <20180226234144.032af030@alma-ubu> <87woyxt3nz.fsf@fastmail.com> <20180316173044.dctlydfij7smndxd@abyayala> <87h8pfc3tr.fsf@fastmail.com> <20180316175225.7jf4k2qaciyxnepp@abyayala> <20180725080800.stqijlny6om6powe@abyayala> <87tvo9c6cs.fsf@fastmail.com> <20180805161802.bif4ax5feqloxayz@abyayala> <87lg9kd61u.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="el2ejmdr5osmi7mb" Content-Disposition: inline In-Reply-To: <87lg9kd61u.fsf@fastmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 28004@debbugs.gnu.org, ng0 --el2ejmdr5osmi7mb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Marius Bakke transcribed 3.2K bytes: > ng0 writes: >=20 > > Once we merge this into master, can we document the update procedure? > > Or even better, write an update script if possible? For me it was 40% > > hit everything which doesn't move and take what's left over and 60% > > reading. I understand the code, but some people might want an > > explanation for how it's decided which folder gets to stay. >=20 > The "preserved-club" are simply third_party directories that are > necessary for the build. Removing any single one will cause the build > to fail (in theory, there might be outdated entries..). >=20 > It's difficult to automate because you don't know what's needed until > the build process starts and fails because of some missing dependency. Hm okay. Yes, I noticed. But they usually fail very early, so it's just 4 - 20 minutes waiting depending on your harddrive and network speed. > > Not related to this section, but: NixOS has a "sandbox" output for Chro= mium > > which "contains the sandboxed wrapper" of Chromium. Maybe it requires s= omething > > Nix/NixOS specific, maybe we can add that. >=20 > I guess that's for the SUID sandbox binary. I haven't had a reason to > build that because the user namespace sandbox works just fine. Perhaps > it's useful for distributions that don't have user namespaces enabled? Maybe, it's worth investigating. I haven't looked at it very much. >=20 > >> + ;; TODO: Install icons from "../../chrome/app/themes= " into > >> + ;; "out/share/icons/hicolor/$size". > > > > I have more icons here in my definition, the whole section looked like.= =2E. > > > >> + (install-file > >> + "product_logo_48.png" > >> + (string-append out "/share/icons/48x48/chromium.png= ")) > > > > this: > > > > + ;; XXX: What about ../../chrome/app/theme/chromium/li= nux/? > > + (for-each > > + (lambda (file) > > + (let* ((size (string-filter char-numeric? file)) > > + (icons (string-append out "/share/icons/hic= olor/" > > + size "x" size "/apps"= ))) > > + (mkdir-p icons) > > + (copy-file file (string-append icons "/chromium.= png")))) > > + '("../../chrome/app/theme/chromium/product_logo_128.= png" > > + "../../chrome/app/theme/chromium/product_logo_22.p= ng" > > + "../../chrome/app/theme/chromium/product_logo_22_m= ono.png" > > + "../../chrome/app/theme/chromium/product_logo_24.p= ng" > > + "../../chrome/app/theme/chromium/product_logo_256.= png" > > + "../../chrome/app/theme/chromium/product_logo_48.p= ng" > > + "../../chrome/app/theme/chromium/product_logo_64.p= ng")) >=20 > Nice. Now the next step is to generate the latter list, maybe with > find-files? >=20 > Thanks for the feedback! Thanks for your continued work on this monster ;) --el2ejmdr5osmi7mb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAltnXtYACgkQ4i+bv+40 hYgK7g//aLZYqsqZBhgj4yyB3tY3LDqEmyBeRB9Tvw2G+X5ec9nYoU/W8c0u7vFh Za6xUuIa2DtKeyxq4++8+nA6AaX0ajwg6NpmxepRqgSJaCA9GrnPFHWG09vZ7Yjr K6VljcKwacTw9ABezE21szDx1Rk8OSvncgO64L4VVuee9Q/TBNUWpnEXJuvipKXL drSp+wbJMeIOmHoy/HzR/bleJpVu/JKxL5gyCarcIKfbqIwjNb6JG4RqSUt9i4aP M1ofQLS/ITTLOJo4OoE64KyqvgC3F3XP45oaP9iC4JOBefeNugGQYWRmJNXaHtkC dVnacmhI5zqdKUj2lROq7jEY/YWKGx0g+Y5qp99DLUUHLCuUfp29pMQniwkBKjcU 1PJsPUl1eTtoGtpmfXed1eimgF0otiGGaVSSnNP4FbWOHLBF5FL5Qq2t1ag/wFck W6HlJ/3TL4Ynf7m157nDz8FNGTEZWbqtzh3gqGaHjcJznnrh2agNngGP5MkgZgqV uEooahQG27kKWIVzG5Q+rTd04r5AGWJnJPlfRW4aJrawxKRFDrEpNaLbUsl9c3Bf sMlOuPtqMub9rl/FQRABtHN0E+Q+BPVZVr3Dtf1oqk7m69ZVkdTX4EokHt6NAjoX 4wPMOfEwqmdK6woZG1kUTFxXd8tXBaSsIbT5lgYVnSUsD/BfFHQ= =EkBc -----END PGP SIGNATURE----- --el2ejmdr5osmi7mb--