all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: 32370@debbugs.gnu.org
Subject: [bug#32370] [PATCH 3/4] gnu: Enable tests for ruby-multi-json.
Date: Sun,  5 Aug 2018 15:43:21 +0100	[thread overview]
Message-ID: <20180805144322.4705-3-mail@cbaines.net> (raw)
In-Reply-To: <20180805144322.4705-1-mail@cbaines.net>

From: Ben Woodcroft <donttrustben@gmail.com>

* gnu/packages/ruby.scm (ruby-multi-json)[version]: Update to 1.13.1.
[source]: Switch to GitHub, so that the tests can be run.
[arguments]: Enable running the tests, and add a patch to fix an issue running
the tests.
[native-inputs]: Add native-inputs required for running the tests.
[home-page]: Use HTTPS.

Signed-off-by: Christopher Baines <mail@cbaines.net>
---
 gnu/packages/ruby.scm | 27 ++++++++++++++++++++++-----
 1 file changed, 22 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 508bbe8c3..888a31e89 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -2268,23 +2268,40 @@ net/http library.")
 (define-public ruby-multi-json
   (package
     (name "ruby-multi-json")
-    (version "1.12.2")
+    (version "1.13.1")
     (source
      (origin
        (method url-fetch)
-       (uri (rubygems-uri "multi_json" version))
+       ;; Tests are not distributed at rubygems.org so download from GitHub
+       ;; instead.
+       (uri (string-append "https://github.com/intridea/multi_json/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
        (sha256
         (base32
-         "1raim9ddjh672m32psaa9niw67ywzjbxbdb8iijx3wv9k5b0pk2x"))))
+         "1s64xqvrnrxmb59v6b2kchnisawg5ai9ky1w60dy6z6ws9la1xv4"))))
     (build-system ruby-build-system)
     (arguments
-     '(#:tests? #f)) ;; No testsuite included in the gem.
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'remove-signing-key-reference
+           (lambda _
+             (substitute* "multi_json.gemspec"
+               ((".*spec.signing_key.*") ""))
+             #t)))))
+    (native-inputs
+     `(("bundler" ,bundler)
+       ("ruby-rspec" ,ruby-rspec)
+       ("ruby-yard" ,ruby-yard)
+       ("ruby-json-pure" ,ruby-json-pure)
+       ("ruby-oj" ,ruby-oj)
+       ("ruby-yajl-ruby" ,ruby-yajl-ruby)))
     (synopsis "Common interface to multiple JSON libraries for Ruby")
     (description
      "This package provides a common interface to multiple JSON libraries,
 including Oj, Yajl, the JSON gem (with C-extensions), the pure-Ruby JSON gem,
 NSJSONSerialization, gson.rb, JrJackson, and OkJson.")
-    (home-page "http://github.com/intridea/multi_json")
+    (home-page "https://github.com/intridea/multi_json")
     (license license:expat)))
 
 (define-public ruby-arel
-- 
2.18.0

  parent reply	other threads:[~2018-08-05 14:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-05 14:39 [bug#32370] [PATCH 0/4] A few Ruby related patches Christopher Baines
2018-08-05 14:43 ` [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby Christopher Baines
2018-08-05 14:43   ` [bug#32370] [PATCH 2/4] gnu: Add ruby-oj Christopher Baines
2018-08-06 22:30     ` Björn Höfling
2018-08-28 20:38       ` Christopher Baines
2018-08-05 14:43   ` Christopher Baines [this message]
2018-08-06 22:31     ` [bug#32370] [PATCH 3/4] gnu: Enable tests for ruby-multi-json Björn Höfling
2018-08-28 20:25       ` Christopher Baines
2018-08-05 14:43   ` [bug#32370] [PATCH 4/4] gnu: Add ruby-multi-test Christopher Baines
2018-08-06 22:30     ` Björn Höfling
2018-08-28 20:30       ` Christopher Baines
2018-08-29  4:53         ` Leo Famulari
2018-08-06 22:28   ` [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby Björn Höfling
2018-08-28 20:47     ` Christopher Baines
2018-08-28 20:33 ` Christopher Baines
2018-08-28 20:33   ` [bug#32370] [PATCH 2/4] gnu: Add ruby-oj Christopher Baines
2018-08-28 20:34   ` [bug#32370] [PATCH 3/4] gnu: Enable tests for ruby-multi-json Christopher Baines
2018-08-28 20:34   ` [bug#32370] [PATCH 4/4] gnu: Add ruby-multi-test Christopher Baines
2018-09-11  6:26   ` [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby Björn Höfling
2018-09-16 17:33     ` bug#32370: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180805144322.4705-3-mail@cbaines.net \
    --to=mail@cbaines.net \
    --cc=32370@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.