all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#32321] [PATCH] gnu: Add povray.
@ 2018-07-30 20:53 Kei Kebreau
  2018-07-31  2:36 ` Kei Kebreau
  0 siblings, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2018-07-30 20:53 UTC (permalink / raw)
  To: 32321; +Cc: Kei Kebreau

* gnu/packages/graphics.scm (povray): New variable.
---
 gnu/packages/graphics.scm | 57 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index ad5ff8ed1..d3caba64d 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -456,6 +456,63 @@ virtual reality, scientific visualization and modeling.")
     ;; LGPL 2.1, but with 4 exceptions. This version is called OSGPL.
     (license license:lgpl2.1)))
 
+(define-public povray
+  (package
+    (name "povray")
+    (version "3.7.0.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/POV-Ray/povray/archive/v"
+                                  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1r2xaym48gmnh577h41ccs3i7dpg7aw0x838y4m4bz3j56yixlak"))
+              (modules '((guix build utils)))
+              (snippet
+               '(begin
+                  ;; Delete bundled libraries.
+                  (delete-file-recursively "libraries")
+                  #t))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)))
+    (inputs
+     `(("boost" ,boost)
+       ("libjpeg" ,libjpeg)
+       ("libpng" ,libpng)
+       ("libtiff" ,libtiff)
+       ("openexr" ,openexr)
+       ("sdl" ,sdl)
+       ("zlib" ,zlib)))
+    (arguments
+     '(#:configure-flags
+       (list "COMPILED_BY=Guix"
+             (string-append "--with-boost-libdir="
+                            (assoc-ref %build-inputs "boost") "/lib")
+             "CXXFLAGS=-std=c++11")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'run-prebuild
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (with-directory-excursion "unix"
+               (invoke "sh" "prebuild.sh"))
+             #t)))))
+    (synopsis "Tool for creating three-dimensional graphics")
+    (description
+     "@code{POV-Ray} is short for the Persistence of Vision Raytracer, a tool
+for producing high-quality computer graphics.  @code{POV-Ray} creates
+three-dimensional, photo-realistic images using a rendering technique called
+ray-tracing.  It reads in a text file containing information describing the
+objects and lighting in a scene and generates an image of that scene from the
+view point of a camera also described in the text file.  Ray-tracing is not a
+fast process by any means, but it produces very high quality images with
+realistic reflections, shading, perspective and other effects.")
+    (home-page "http://www.povray.org/")
+    (license license:agpl3+)))
+
 (define-public rapicorn
   (package
     (name "rapicorn")
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#32321] [PATCH] gnu: Add povray.
  2018-07-30 20:53 [bug#32321] [PATCH] gnu: Add povray Kei Kebreau
@ 2018-07-31  2:36 ` Kei Kebreau
  2018-08-02 15:25   ` Efraim Flashner
  0 siblings, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2018-07-31  2:36 UTC (permalink / raw)
  To: 32321


[-- Attachment #1.1: Type: text/plain, Size: 86 bytes --]

The attached patch disables CPU-specific optimization and fixes
detection of OpenEXR.

[-- Attachment #1.2: 0001-gnu-Add-povray.patch --]
[-- Type: text/plain, Size: 3204 bytes --]

From fd4cae93f6c6eb4a8573ae02ad783ff39cd5279d Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kkebreau@posteo.net>
Date: Mon, 30 Jul 2018 16:25:21 -0400
Subject: [PATCH] gnu: Add povray.

* gnu/packages/graphics.scm (povray): New variable.
---
 gnu/packages/graphics.scm | 59 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index ad5ff8ed1..585215956 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -456,6 +456,65 @@ virtual reality, scientific visualization and modeling.")
     ;; LGPL 2.1, but with 4 exceptions. This version is called OSGPL.
     (license license:lgpl2.1)))
 
+(define-public povray
+  (package
+    (name "povray")
+    (version "3.7.0.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/POV-Ray/povray/archive/v"
+                                  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1r2xaym48gmnh577h41ccs3i7dpg7aw0x838y4m4bz3j56yixlak"))
+              (modules '((guix build utils)))
+              (snippet
+               '(begin
+                  ;; Delete bundled libraries.
+                  (delete-file-recursively "libraries")
+                  #t))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("boost" ,boost)
+       ("libjpeg" ,libjpeg)
+       ("libpng" ,libpng)
+       ("libtiff" ,libtiff)
+       ("openexr" ,openexr)
+       ("sdl" ,sdl)
+       ("zlib" ,zlib)))
+    (arguments
+     '(#:configure-flags
+       (list "COMPILED_BY=Guix"
+             (string-append "--with-boost-libdir="
+                            (assoc-ref %build-inputs "boost") "/lib")
+             "CXXFLAGS=-std=c++11"
+             "--disable-optimiz-arch")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'run-prebuild
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (with-directory-excursion "unix"
+               (invoke "sh" "prebuild.sh"))
+             #t)))))
+    (synopsis "Tool for creating three-dimensional graphics")
+    (description
+     "@code{POV-Ray} is short for the Persistence of Vision Raytracer, a tool
+for producing high-quality computer graphics.  @code{POV-Ray} creates
+three-dimensional, photo-realistic images using a rendering technique called
+ray-tracing.  It reads in a text file containing information describing the
+objects and lighting in a scene and generates an image of that scene from the
+view point of a camera also described in the text file.  Ray-tracing is not a
+fast process by any means, but it produces very high quality images with
+realistic reflections, shading, perspective and other effects.")
+    (home-page "http://www.povray.org/")
+    (license license:agpl3+)))
+
 (define-public rapicorn
   (package
     (name "rapicorn")
-- 
2.18.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#32321] [PATCH] gnu: Add povray.
  2018-07-31  2:36 ` Kei Kebreau
@ 2018-08-02 15:25   ` Efraim Flashner
  2018-08-02 18:05     ` Kei Kebreau
  0 siblings, 1 reply; 6+ messages in thread
From: Efraim Flashner @ 2018-08-02 15:25 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: 32321

[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]

On Mon, Jul 30, 2018 at 10:36:00PM -0400, Kei Kebreau wrote:

> +    (version "3.7.0.8")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/POV-Ray/povray/archive/v"
> +                                  version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))

Don't use the unstable tarball, download it using git-fetch.

> +              (sha256
> +               (base32
> +                "1r2xaym48gmnh577h41ccs3i7dpg7aw0x838y4m4bz3j56yixlak"))
<snip>
> +             (string-append "--with-boost-libdir="
> +                            (assoc-ref %build-inputs "boost") "/lib")
> +             "CXXFLAGS=-std=c++11"
> +             "--disable-optimiz-arch")

I have to ask, is 'optimiz' spelled correctly?

> +       #:phases
<snip>

It built without any problems for me on aarch64



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#32321] [PATCH] gnu: Add povray.
  2018-08-02 15:25   ` Efraim Flashner
@ 2018-08-02 18:05     ` Kei Kebreau
  2018-08-03  1:52       ` Kei Kebreau
  0 siblings, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2018-08-02 18:05 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 32321

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

Efraim Flashner <efraim@flashner.co.il> writes:

> On Mon, Jul 30, 2018 at 10:36:00PM -0400, Kei Kebreau wrote:
>
>> +    (version "3.7.0.8")
>> +    (source (origin
>> +              (method url-fetch)
>> + (uri (string-append "https://github.com/POV-Ray/povray/archive/v"
>> +                                  version ".tar.gz"))
>> +              (file-name (string-append name "-" version ".tar.gz"))
>
> Don't use the unstable tarball, download it using git-fetch.

If I'm not misunderstanding POV-Ray's version numbering scheme, this is
a source code maintainance release with no changes in functionality.
See "https://github.com/POV-Ray/povray/releases/tag/v3.7.0.8".

>
>> +              (sha256
>> +               (base32
>> +                "1r2xaym48gmnh577h41ccs3i7dpg7aw0x838y4m4bz3j56yixlak"))
> <snip>
>> +             (string-append "--with-boost-libdir="
>> +                            (assoc-ref %build-inputs "boost") "/lib")
>> +             "CXXFLAGS=-std=c++11"
>> +             "--disable-optimiz-arch")
>
> I have to ask, is 'optimiz' spelled correctly?

Indeed it is. See "https://github.com/POV-Ray/povray/search?q=optimiz" (or
just grep in "unix/install.txt" and "unix/configure.ac" in the source
distribution).

>
>> +       #:phases
> <snip>
>
> It built without any problems for me on aarch64

Excellent, and thanks for reviewing!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#32321] [PATCH] gnu: Add povray.
  2018-08-02 18:05     ` Kei Kebreau
@ 2018-08-03  1:52       ` Kei Kebreau
  2018-08-05  4:32         ` bug#32321: " Kei Kebreau
  0 siblings, 1 reply; 6+ messages in thread
From: Kei Kebreau @ 2018-08-03  1:52 UTC (permalink / raw)
  To: Efraim Flashner; +Cc: 32321

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

Kei Kebreau <kkebreau@posteo.net> writes:

> Efraim Flashner <efraim@flashner.co.il> writes:
>
>> On Mon, Jul 30, 2018 at 10:36:00PM -0400, Kei Kebreau wrote:
>>
>>> +    (version "3.7.0.8")
>>> +    (source (origin
>>> +              (method url-fetch)
>>> + (uri (string-append "https://github.com/POV-Ray/povray/archive/v"
>>> +                                  version ".tar.gz"))
>>> +              (file-name (string-append name "-" version ".tar.gz"))
>>
>> Don't use the unstable tarball, download it using git-fetch.
>
> If I'm not misunderstanding POV-Ray's version numbering scheme, this is
> a source code maintainance release with no changes in functionality.
> See "https://github.com/POV-Ray/povray/releases/tag/v3.7.0.8".
>

Never mind about the unstable tarball bit. After further research, about
GitHub's archive generation, I now see what you mean. Apparently many
other projects get hit with this bug as well. I'll switch to using
git-fetch and push this to master after some more testing. Thanks again!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#32321: [PATCH] gnu: Add povray.
  2018-08-03  1:52       ` Kei Kebreau
@ 2018-08-05  4:32         ` Kei Kebreau
  0 siblings, 0 replies; 6+ messages in thread
From: Kei Kebreau @ 2018-08-05  4:32 UTC (permalink / raw)
  To: 32321-done

[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]

Kei Kebreau <kkebreau@posteo.net> writes:

> Kei Kebreau <kkebreau@posteo.net> writes:
>
>> Efraim Flashner <efraim@flashner.co.il> writes:
>>
>>> On Mon, Jul 30, 2018 at 10:36:00PM -0400, Kei Kebreau wrote:
>>>
>>>> +    (version "3.7.0.8")
>>>> +    (source (origin
>>>> +              (method url-fetch)
>>>> + (uri (string-append "https://github.com/POV-Ray/povray/archive/v"
>>>> +                                  version ".tar.gz"))
>>>> +              (file-name (string-append name "-" version ".tar.gz"))
>>>
>>> Don't use the unstable tarball, download it using git-fetch.
>>
>> If I'm not misunderstanding POV-Ray's version numbering scheme, this is
>> a source code maintainance release with no changes in functionality.
>> See "https://github.com/POV-Ray/povray/releases/tag/v3.7.0.8".
>>
>
> Never mind about the unstable tarball bit. After further research, about
> GitHub's archive generation, I now see what you mean. Apparently many
> other projects get hit with this bug as well. I'll switch to using
> git-fetch and push this to master after some more testing. Thanks again!

Pushed to master as 340ee00bb.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-08-05  4:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-30 20:53 [bug#32321] [PATCH] gnu: Add povray Kei Kebreau
2018-07-31  2:36 ` Kei Kebreau
2018-08-02 15:25   ` Efraim Flashner
2018-08-02 18:05     ` Kei Kebreau
2018-08-03  1:52       ` Kei Kebreau
2018-08-05  4:32         ` bug#32321: " Kei Kebreau

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.