all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nils Gillmann <ng0@n0.is>
To: Jelle Licht <jlicht@fsfe.org>
Cc: Ricardo Wurmus <rekado@elephly.net>,
	h.goebel@crazy-compilers.com, 29951@debbugs.gnu.org
Subject: [bug#29951] [PATCH] WIP guix: Add wrap-script.
Date: Thu, 2 Aug 2018 09:22:55 +0000	[thread overview]
Message-ID: <20180802092255.hmdu5p3a5y7wbm37@abyayala> (raw)
In-Reply-To: <CAPsKtfJDw=ba=8a3CUHnif9PkruQ-B0ui5nTY1C+1gQSXfRiGg@mail.gmail.com>

Jelle Licht transcribed 4.1K bytes:
> 2018-01-02 21:44 GMT+01:00 Ricardo Wurmus <rekado@elephly.net>:
> 
> > * guix/build/utils.scm (wrap-script): New procedure.
> > ---
> >  guix/build/utils.scm | 101 ++++++++++++++++++++++++++++++
> > +++++++++++++++++++++
> >  1 file changed, 101 insertions(+)
> >
> > diff --git a/guix/build/utils.scm b/guix/build/utils.scm
> > index 7391307c8..a2efcb31c 100644
> > --- a/guix/build/utils.scm
> > +++ b/guix/build/utils.scm
> > @@ -3,6 +3,7 @@
> >  ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
> >  ;;; Copyright © 2013 Nikita Karetnikov <nikita@karetnikov.org>
> >  ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
> > +;;; Copyright © 2018 Ricardo Wurmus <rekado@elephly.net>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -84,6 +85,7 @@
> >              fold-port-matches
> >              remove-store-references
> >              wrap-program
> > +            wrap-script
> >              invoke
> >
> >              locale-category->string))
> > @@ -1068,6 +1070,105 @@ with definitions for VARS."
> >          (chmod prog-tmp #o755)
> >
> 
> [...]
> 
> >      (rename-file prog-tmp prog))))
> >
> > +(define wrap-script
> > +  (let ((interpreter-regex
> > +         (make-regexp
> > +          (string-append "^#! ?(/bin/sh|/gnu/store/[^/]+/bin/("
> >
> 
> Won't this be an issue for people using a customized store location?

Can't we make this substitutable at configure time?

> [snipped]
> >

  parent reply	other threads:[~2018-08-02  9:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-02 20:44 [bug#29951] [PATCH] WIP guix: Add wrap-script Ricardo Wurmus
2018-01-03 13:59 ` Hartmut Goebel
2018-01-05  8:19   ` Ricardo Wurmus
2018-01-05 10:06     ` Hartmut Goebel
2018-08-02  6:26     ` Chris Marusich
2018-08-02  7:23       ` Ricardo Wurmus
2018-08-02  8:37         ` Chris Marusich
2018-01-12 22:52 ` Ludovic Courtès
2018-08-02  8:18 ` Jelle Licht
2018-08-02  8:37   ` Ricardo Wurmus
2018-08-02  9:22   ` Nils Gillmann [this message]
2019-02-06 23:10 ` [bug#29951] [PATCH]: " Ricardo Wurmus
2019-02-08 10:10   ` bug#29951: " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180802092255.hmdu5p3a5y7wbm37@abyayala \
    --to=ng0@n0.is \
    --cc=29951@debbugs.gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    --cc=jlicht@fsfe.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.