[bug#32256] [PATCH] gnu: Add nudoku.

[bug#32256] [PATCH] gnu: Add nudoku.

[Ricardo Wurmus]

From: Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>

* gnu/packages/games.scm (nudoku): New variable.

Signed-off-by: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
---
 gnu/packages/games.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 4af0b52e8..c2e35791f 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -33,6 +33,7 @@
 ;;; Copyright © 2017, 2018 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;; Copyright © 2018 okapi <okapi@firemail.cc>
 ;;; Copyright © 2018 Tim Gesthuizen <tim.gesthuizen@yahoo.de>
+;;; Copyright © 2018 Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4714,6 +4715,25 @@ making Yamagi Quake II one of the most solid Quake II implementations available.
                     "See Info-Zip section.")
                    license:public-domain)))) ; stb
 
+(define-public nudoku
+  (package
+    (name "nudoku")
+    (version "1.0.0")
+    (source (origin
+	      (method url-fetch)
+	      (uri (string-append "https://github.com/jubalh/nudoku/"
+                                  "releases/download/" version
+                                  "/nudoku-" version ".tar.xz"))
+	      (sha256
+               (base32
+                "0nr2j2z07nxk70s8xnmmpzccxicf7kn5mbwby2kg6aq8paarjm8k"))))
+    (build-system gnu-build-system)
+    (inputs `(("ncurses" ,ncurses)))
+    (home-page "https://jubalh.github.io/nudoku/")
+    (synopsis "Sudoku for your terminal")
+    (description "nudoku is a ncurses based sudoku game.")
+    (license license:gpl3+)))
+
 (define-public the-butterfly-effect
   (package
     (name "the-butterfly-effect")
-- 
2.18.0

[bug#32256] [PATCH] gnu: Add nudoku.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

> From: Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>
>
> * gnu/packages/games.scm (nudoku): New variable.
>
> Signed-off-by: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> ---
>  gnu/packages/games.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 4af0b52e8..c2e35791f 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -33,6 +33,7 @@
>  ;;; Copyright © 2017, 2018 Nicolas Goaziou <mail@nicolasgoaziou.fr>
>  ;;; Copyright © 2018 okapi <okapi@firemail.cc>
>  ;;; Copyright © 2018 Tim Gesthuizen <tim.gesthuizen@yahoo.de>
> +;;; Copyright © 2018 Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -4714,6 +4715,25 @@ making Yamagi Quake II one of the most solid Quake II implementations available.
>                      "See Info-Zip section.")
>                     license:public-domain)))) ; stb
>  
> +(define-public nudoku
> +  (package
> +    (name "nudoku")
> +    (version "1.0.0")
> +    (source (origin
> +	      (method url-fetch)
> +	      (uri (string-append "https://github.com/jubalh/nudoku/"
> +                                  "releases/download/" version
> +                                  "/nudoku-" version ".tar.xz"))
> +	      (sha256
> +               (base32
> +                "0nr2j2z07nxk70s8xnmmpzccxicf7kn5mbwby2kg6aq8paarjm8k"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("ncurses" ,ncurses)))
> +    (home-page "https://jubalh.github.io/nudoku/")
> +    (synopsis "Sudoku for your terminal")
> +    (description "nudoku is a ncurses based sudoku game.")

I'd use "@code{nudoku}" here because it's the name of a program.

> +    (license license:gpl3+)))
> +
>  (define-public the-butterfly-effect
>    (package
>      (name "the-butterfly-effect")

Otherwise this looks fine and works well for me!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#32256: [PATCH] gnu: Add nudoku.

[Ricardo Wurmus]

Hi Kei,

> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>
>> From: Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>
>>
>> * gnu/packages/games.scm (nudoku): New variable.
>>
>> Signed-off-by: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
>> ---
[…]
>> +    (description "nudoku is a ncurses based sudoku game.")
>
> I'd use "@code{nudoku}" here because it's the name of a program.
>
>> +    (license license:gpl3+)))
>> +
>>  (define-public the-butterfly-effect
>>    (package
>>      (name "the-butterfly-effect")
>
> Otherwise this looks fine and works well for me!

Thanks for your input.  I changed the description, but ended up not
using @code{} here.

-- 
Ricardo

[bug#32256] [PATCH] gnu: Add nudoku.

[Tobias Geerinckx-Rice]

Kei,

Just an aside on this important matter.

Kei Kebreau wrote:
>> +    (description "nudoku is a ncurses based sudoku game.")
>
> I'd use "@code{nudoku}" here because it's the name of a program.

While there's some precedent in Guix for using @code{} for marking 
up package names when they'll be used mainly in actual source code 
(e.g. @code{My::Perl::Module}), that's a specific case with a 
specific rationale.

A more suitable tag here would be @command{}. However, there seems 
to be an informal(?) consensus not to use it when talking about 
the package as a whole/project, but only when referring to the 
actual command (binary) itself. Some descriptions don't follow 
that convention, though, so it's at best a grey area.

I don't think programme names should be marked up all purdy just 
for being programmes.

Kind regards,

T G-R

[bug#32256] [PATCH] gnu: Add nudoku.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Kei,
>
> Just an aside on this important matter.
>
> Kei Kebreau wrote:
>>> +    (description "nudoku is a ncurses based sudoku game.")
>>
>> I'd use "@code{nudoku}" here because it's the name of a program.
>
> While there's some precedent in Guix for using @code{} for marking up
> package names when they'll be used mainly in actual source code
> (e.g. @code{My::Perl::Module}), that's a specific case with a specific
> rationale.
>
> A more suitable tag here would be @command{}. However, there seems to
> be an informal(?) consensus not to use it when talking about the
> package as a whole/project, but only when referring to the actual
> command (binary) itself. Some descriptions don't follow that
> convention, though, so it's at best a grey area.
>
> I don't think programme names should be marked up all purdy just for
> being programmes.
>
> Kind regards,
>
> T G-R

Alright. Hopefully I'll pick up more on these hints as I read more
documentation source code.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]