From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fd1f1-0004ya-CY for guix-patches@gnu.org; Tue, 10 Jul 2018 19:03:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fd1ex-0002XJ-Vw for guix-patches@gnu.org; Tue, 10 Jul 2018 19:03:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46555) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fd1ex-0002X1-QE for guix-patches@gnu.org; Tue, 10 Jul 2018 19:03:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fd1ex-0006Ig-DL for guix-patches@gnu.org; Tue, 10 Jul 2018 19:03:03 -0400 Subject: [bug#32121] [PATCH 1/5] base: Compile CHECKOUT in the fiber. References: <87lgain1fp.fsf@lassieur.org> In-Reply-To: <87lgain1fp.fsf@lassieur.org> Resent-Message-ID: From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Date: Wed, 11 Jul 2018 01:02:43 +0200 Message-Id: <20180710230247.16639-1-clement@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 32121@debbugs.gnu.org Because it may take time and thus prevent PROCESS-SPECS to run every INTERVAL seconds. * src/cuirass/base.scm (process-specs): move the COMPILE invocation inside SPAWN-FIBER's thunk. Add log message. --- src/cuirass/base.scm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cuirass/base.scm b/src/cuirass/base.scm index 9985fd6..de54f72 100644 --- a/src/cuirass/base.scm +++ b/src/cuirass/base.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2016, 2017 Mathieu Lirzin ;;; Copyright © 2017 Mathieu Othacehe ;;; Copyright © 2017 Ricardo Wurmus +;;; Copyright © 2018 Clément Lassieur ;;; ;;; This file is part of Cuirass. ;;; @@ -631,12 +632,11 @@ procedure is meant to be called at startup." ;; Immediately mark COMMIT as being processed so we don't spawn ;; a concurrent evaluation of that same commit. (db-add-stamp db spec commit) - - (when compile? - (non-blocking (compile checkout))) - (spawn-fiber (lambda () + (when compile? + (log-message "compiling '~a' with commit ~s" name commit) + (non-blocking (compile checkout))) (guard (c ((evaluation-error? c) (log-message "failed to evaluate spec '~s'" (evaluation-error-spec-name c)) -- 2.18.0