From: Leo Famulari <leo@famulari.name>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 31818@debbugs.gnu.org
Subject: [bug#31818] [PATCH] gnu: Add restic.
Date: Wed, 13 Jun 2018 21:26:08 -0400 [thread overview]
Message-ID: <20180614012608.GA29167@jasmine.lan> (raw)
In-Reply-To: <20180613191819.7460-1-go.wigust@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]
On Wed, Jun 13, 2018 at 10:18:19PM +0300, Oleg Pykhalov wrote:
> * gnu/packages/backup.scm (restic): New variable.
Cool, thanks for this!
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/restic/restic/releases/download/"
> + "v" version "/restic-" version ".tar.gz"))
This tarball includes bundled copies of restic's dependency graph in the
vendor directory.
Adding the package to Guix with the bundled libraries is not how we
usually do things but, if they are all free software, it could be okay.
For Syncthing I unbundled everything — see (gnu packages syncthing).
Go presents a challenge for downstream packagers due to the humongous
dependency graphs of unversioned libraries. Our tooling could handle
this better than it currently does [0], but I don't think we should let
this hold us back now that we are getting patches for Go software :)
Does anyone have opinions about the bundled ("vendored") code in this
package?
> + (replace 'build
> + (lambda* (#:key inputs #:allow-other-keys)
> + (with-directory-excursion (string-append
> + "src/github.com/restic/restic/restic-"
> + ,version)
> + (invoke "go" "run" "build.go"))))
It would be nice if this could be made verbose — currently the build
phase is totally silent.
[0]
<https://lists.gnu.org/archive/html/guix-devel/2017-10/msg00030.html>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-06-14 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 19:18 [bug#31818] [PATCH] gnu: Add restic Oleg Pykhalov
2018-06-14 1:26 ` Leo Famulari [this message]
2018-06-14 13:58 ` Oleg Pykhalov
2018-06-14 19:06 ` Leo Famulari
2018-06-16 18:54 ` Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614012608.GA29167@jasmine.lan \
--to=leo@famulari.name \
--cc=31818@debbugs.gnu.org \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.