From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53606)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fS3xj-0004Bs-Tf
	for guix-patches@gnu.org; Sun, 10 Jun 2018 13:17:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fS3xe-0004Q1-V3
	for guix-patches@gnu.org; Sun, 10 Jun 2018 13:17:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34626)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fS3xe-0004Ph-Qc
	for guix-patches@gnu.org; Sun, 10 Jun 2018 13:17:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fS3xe-0007hV-EF
	for guix-patches@gnu.org; Sun, 10 Jun 2018 13:17:02 -0400
Subject: [bug#31774] [PATCH 12/22] gnu: Add maven-core.
Resent-Message-ID: <handler.31774.B31774.152865101229583@debbugs.gnu.org>
Date: Sun, 10 Jun 2018 19:16:43 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20180610191643.15f8a63e@scratchpost.org>
In-Reply-To: <20180610110319.24043-12-julien@lepiller.eu>
References: <20180610130104.2b154715@lepiller.eu>
	<20180610110319.24043-1-julien@lepiller.eu>
	<20180610110319.24043-12-julien@lepiller.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	boundary="Sig_/QKzEpwUFgA3ZNaNq/CtW1V/";
	protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 31774@debbugs.gnu.org

--Sig_/QKzEpwUFgA3ZNaNq/CtW1V/
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Julien,

On Sun, 10 Jun 2018 13:03:09 +0200
Julien Lepiller <julien@lepiller.eu> wrote:

> +                ;; FIXME: This should be taken care of by plexus-compone=
nt-metadata directly

Is this possible now?

> +                (invoke "sh" "-c"
> +                        (string-append
> +                          "(cat build/classes/META-INF/plexus/components=
.t.xml |"
> +                          "sed -e 's|</component-set>||' -e 's|</compone=
nts>||' ; "
> +                          "cat src/main/resources/META-INF/plexus/artifa=
ct-handlers.xml |"
> +                          " sed -e 's|<?xml.*||' -e 's|<component-set>||=
' -e 's|<components>||'"
> +                          " -e 's|</component-set>||' -e 's|</components=
>||'; "
> +                          "cat src/main/resources/META-INF/plexus/compon=
ents.xml |"
> +                          " sed -e 's|<?xml.*||' -e 's|<component-set>||=
' -e 's|<components>||'"
> +                          " -e 's|</component-set>||' -e 's|</components=
>||'; "
> +                          "cat src/main/resources/META-INF/plexus/defaul=
t-bindings.xml |"
> +                          " sed -e 's|<?xml.*||' -e 's|<component-set>||=
' -e 's|<components>||' )>"
> +                          "build/classes/META-INF/plexus/components.xml"=
))

XML isn't really line-based, so using (sxml simple) to merge would be more =
reliable.
Error reporting would be better, too.

https://www.gnu.org/software/guile/manual/html_node/Reading-and-Writing-XML=
.html#Reading-and-Writing-XML

--Sig_/QKzEpwUFgA3ZNaNq/CtW1V/
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlsdXPsACgkQ5xo1VCww
uqWytgf/SaCVoCaJyzdLpVqCcXknin3xa2w67v5tNlUSr89Tdy7md5TViYtgXfsR
gfvw5oEiGqWJ+TeDOMJgWsq0kGrsT3FdTFWOl8ixjJ41U7g31I2MohXikKMD7VcU
R/s98stgP2LefukxqEaON+kIT+8JK5KhVBbvyt05FDcmVI3yWIESCw8KxBGC3SXs
gPrMlGehOiB3Xd7AJq3fzeRdv9Iz3zs7mEjdhMlkOZ9Tsy4Aij5lX50MZCPFUEmw
HuXMkyd1ktFubKHb7KAa/pVQmoFXwqcq2cJh2TqtE9Z3N3onhSTcERQggZ9+ZwK4
r2tc1j7QDQUP2+krV9wiVIjuh/z5wg==
=Eczs
-----END PGP SIGNATURE-----

--Sig_/QKzEpwUFgA3ZNaNq/CtW1V/--