From: Nils Gillmann <ng0@n0.is>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: ng0@n0.is, Rutger Helling <rhelling@mykolab.com>, 30693@debbugs.gnu.org
Subject: [bug#30693] Xonotic
Date: Sat, 26 May 2018 23:21:24 +0000 [thread overview]
Message-ID: <20180526232124.6tc72eh5kirqm7cf@abyayala> (raw)
In-Reply-To: <877enqys46.fsf@gnu.org>
Ludovic Courtès transcribed 514 bytes:
> Hello Rutger & Nils,
>
> Thanks for taking care of this!
>
> One minor issue: ‘x11-style’ is a procedure, not a <license> object,
> hence:
>
> $ ./pre-inst-env guix lint xonotic
> gnu/packages/games.scm:5153:13: xonotic@0.8.2: invalid license field
>
> ‘x11-style’ takes a URI as an argument. I’d fix it myself but I’m not
> sure what needs to go there. Could you take a look? Perhaps ng0 knows
> why ‘x11-style’ is listed?
>
> Thanks in advance,
> Ludo’.
Sorry, no idea. My original patch has x11 instead of x11-style.
As I already wrote, from my perspective this was far from ready for merge,
but basic functionality is there (it works in one mode) and it passed
one review.
I think I changed some bits after moving it out of gnu/packages, but I
haven't read the package definition in a while.
Definitely wasn't me who put x11 instead of x11-style there.
next prev parent reply other threads:[~2018-05-26 23:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 23:34 [bug#30693] Xonotic ng0
2018-03-07 13:00 ` Ludovic Courtès
2018-03-07 13:19 ` ng0
2018-03-07 15:28 ` Ludovic Courtès
2018-05-25 14:41 ` Rutger Helling
2018-05-25 16:52 ` Nils Gillmann
2018-05-26 16:25 ` bug#30693: Xonotic Rutger Helling
2018-05-26 18:43 ` [bug#30693] Xonotic Charlie Ritter
2018-05-26 22:22 ` Ludovic Courtès
2018-05-26 23:21 ` Nils Gillmann [this message]
2018-05-27 8:31 ` Rutger Helling
2018-05-27 13:04 ` Ludovic Courtès
2018-05-27 13:06 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180526232124.6tc72eh5kirqm7cf@abyayala \
--to=ng0@n0.is \
--cc=30693@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=rhelling@mykolab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.