From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMZuW-0005qk-0v for guix-patches@gnu.org; Sat, 26 May 2018 10:11:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMZuR-0008Lg-2R for guix-patches@gnu.org; Sat, 26 May 2018 10:11:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:41884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fMZuQ-0008La-Tn for guix-patches@gnu.org; Sat, 26 May 2018 10:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fMZuQ-0001HS-Ho for guix-patches@gnu.org; Sat, 26 May 2018 10:11:02 -0400 Subject: [bug#31523] [PATCH 0/2] Getting rid of 'title' in 'file-system' declarations Resent-Message-ID: Date: Sat, 26 May 2018 14:10:43 +0000 From: Nils Gillmann Message-ID: <20180526141043.p2x7g6c7g44dwg7l@abyayala> References: <20180518221205.15559-1-ludo@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180518221205.15559-1-ludo@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31523@debbugs.gnu.org Ludovic Courtès transcribed 2.0K bytes: > Hello Guix! > > These patches allow us to get rid of the infamous ‘title’ field in > ‘file-system’ declarations, which has always been problematic. It does > so by introducing a new data type, such that one can > write: > > (file-system > (mount-point "/home") > (type "ext4") > (device (file-system-label "my-home"))) > > which probably looks clearer and is definitely less error prone. > > The ‘title’ field is removed but some macrology takes care of > implementing backward compatibility by detecting ‘title’ fields, issuing > a deprecation warning, and adjusting the ‘device’ value according to the > ‘title’. > > The “installed-os” test passes. > > Feedback welcome! I can not test it at the moment, but I like the example, which looks like it could make it less confusing for newcomers. > Ludo’. > > Ludovic Courtès (2): > file-systems: Remove 'title' field and add . > system: Remove uses of the 'title' field of . > > doc/guix.texi | 68 ++++++------ > gnu/bootloader/grub.scm | 10 +- > gnu/build/file-systems.scm | 54 +++------- > gnu/build/linux-boot.scm | 12 ++- > gnu/build/shepherd.scm | 3 +- > gnu/services/base.scm | 17 ++- > gnu/system.scm | 36 ++++--- > gnu/system/examples/bare-bones.tmpl | 3 +- > gnu/system/examples/beaglebone-black.tmpl | 3 +- > gnu/system/examples/lightweight-desktop.tmpl | 4 +- > gnu/system/examples/vm-image.tmpl | 3 +- > gnu/system/file-systems.scm | 108 ++++++++++++++++--- > gnu/system/install.scm | 4 +- > gnu/system/vm.scm | 7 +- > gnu/tests.scm | 3 +- > gnu/tests/install.scm | 26 ++--- > guix/scripts/system.scm | 31 +++--- > tests/guix-system.sh | 9 +- > tests/system.scm | 6 +- > 19 files changed, 227 insertions(+), 180 deletions(-) > > -- > 2.17.0 > > > >