From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJncV-0001pD-IG for guix-patches@gnu.org; Fri, 18 May 2018 18:13:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJncU-00011F-G9 for guix-patches@gnu.org; Fri, 18 May 2018 18:13:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fJncU-00011A-C7 for guix-patches@gnu.org; Fri, 18 May 2018 18:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fJncU-000836-5K for guix-patches@gnu.org; Fri, 18 May 2018 18:13:02 -0400 Subject: [bug#31523] [PATCH 0/2] Getting rid of 'title' in 'file-system' declarations Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJnbq-0001Uq-0n for guix-patches@gnu.org; Fri, 18 May 2018 18:12:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJnbp-0000dj-1s for guix-patches@gnu.org; Fri, 18 May 2018 18:12:21 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Sat, 19 May 2018 00:12:05 +0200 Message-Id: <20180518221205.15559-1-ludo@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 31523@debbugs.gnu.org Hello Guix! These patches allow us to get rid of the infamous ‘title’ field in ‘file-system’ declarations, which has always been problematic. It does so by introducing a new data type, such that one can write: (file-system (mount-point "/home") (type "ext4") (device (file-system-label "my-home"))) which probably looks clearer and is definitely less error prone. The ‘title’ field is removed but some macrology takes care of implementing backward compatibility by detecting ‘title’ fields, issuing a deprecation warning, and adjusting the ‘device’ value according to the ‘title’. The “installed-os” test passes. Feedback welcome! Ludo’. Ludovic Courtès (2): file-systems: Remove 'title' field and add . system: Remove uses of the 'title' field of . doc/guix.texi | 68 ++++++------ gnu/bootloader/grub.scm | 10 +- gnu/build/file-systems.scm | 54 +++------- gnu/build/linux-boot.scm | 12 ++- gnu/build/shepherd.scm | 3 +- gnu/services/base.scm | 17 ++- gnu/system.scm | 36 ++++--- gnu/system/examples/bare-bones.tmpl | 3 +- gnu/system/examples/beaglebone-black.tmpl | 3 +- gnu/system/examples/lightweight-desktop.tmpl | 4 +- gnu/system/examples/vm-image.tmpl | 3 +- gnu/system/file-systems.scm | 108 ++++++++++++++++--- gnu/system/install.scm | 4 +- gnu/system/vm.scm | 7 +- gnu/tests.scm | 3 +- gnu/tests/install.scm | 26 ++--- guix/scripts/system.scm | 31 +++--- tests/guix-system.sh | 9 +- tests/system.scm | 6 +- 19 files changed, 227 insertions(+), 180 deletions(-) -- 2.17.0