From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHt4X-0001ph-Rr for guix-patches@gnu.org; Sun, 13 May 2018 11:38:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHt4U-0001xw-Lq for guix-patches@gnu.org; Sun, 13 May 2018 11:38:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53060) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHt4U-0001xm-HK for guix-patches@gnu.org; Sun, 13 May 2018 11:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fHt4U-0005Sc-5M for guix-patches@gnu.org; Sun, 13 May 2018 11:38:02 -0400 Subject: [bug#31342] [PATCH 2/2] gnu: services: Add Enlightenment desktop service. Resent-Message-ID: Date: Sun, 13 May 2018 18:36:53 +0300 From: Efraim Flashner Message-ID: <20180513153653.GD1074@macbook41> References: <20180502164723.13994-1-efraim@flashner.co.il> <20180502164723.13994-2-efraim@flashner.co.il> <87bmdr5s2g.fsf@gnu.org> <20180507190327.GA2707@macbook41> <87bmdq46vo.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9UV9rz0O2dU/yYYn" Content-Disposition: inline In-Reply-To: <87bmdq46vo.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31342@debbugs.gnu.org --9UV9rz0O2dU/yYYn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 08, 2018 at 03:24:59PM +0200, Ludovic Court=C3=A8s wrote: > Hello! >=20 > Efraim Flashner skribis: >=20 > > On Mon, May 07, 2018 at 06:49:43PM +0200, Ludovic Court=C3=A8s wrote: >=20 > [...] >=20 > >> Perhaps enlightenment_ckpasswd needs a PAM entry as well, like > >> =E2=80=98screen-locker-service-type=E2=80=99 does? > >>=20 > > > > I'm not sure, enlightenment's screen locker code was refactored in > > 0.22.2 so that it would behave identically on Linux and BSD, and I'm not > > sure that the BSDs use PAM, and it seems to with as-is. >=20 > If you confirm it works as-is, that=E2=80=99s fine! >=20 > >> > +(define* (enlightenment-desktop-service > >> > + #:key (config (enlightenment-desktop-configuration))) > >> > + "Return a service that adds the @code{enlightenment} package to t= he system > >> > +profile, and extends dbus with the ability for @code{efl} to genera= te > >> > +thumbnails and makes setuid the programs which enlightenment expect= s to have > >> > +their setuid bit set." > >> > + (service enlightenment-desktop-service-type config)) > >>=20 > >> Not needed! :-) > >>=20 > >> Thank you, > >> Ludo=E2=80=99. > > > > I looked at the xfce service especially, and it actually has the same > > fields and declarations as enlightenment. >=20 > Sounds good. >=20 > > I'd like to leave the option in place to add > > '(enlightenment-desktop-service)' to an OS-config since it is then > > identical to the other desktop services we have. >=20 > This style has been (informally, I admit) deprecated since we introduced > the =E2=80=98service=E2=80=99 form. The recommended way is to write: >=20 > (service enlightenment-service-type) >=20 > I agree it=E2=80=99s slightly more verbose, but it=E2=80=99s more =E2=80= =9Ctransparent.=E2=80=9D >=20 > Thanks, > Ludo=E2=80=99. I think I have it this time. No 'enlightenment-desktop-service', yes 'enlightenment-desktop-service-type', which takes a configure option of an enlightenment package. I moved the description from up to the service-type and added a "table" detailing all the configure options available. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --9UV9rz0O2dU/yYYn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlr4W5UACgkQQarn3Mo9 g1GouhAAiImd2UaY7xiafcCjTLkrlIrthHKYkj6Qx1AgnqLpjsYWtHlaXrkLSK23 eA2rDurrExM4K6DY5DhIWADXMdmKTIPRVBaIFtSzJeqZq19nFvXfNoouWSkOpJW8 Ds41ZuCWIWwpxVSXc8NjNgnfpo1eixLIPozqY6IuIVjd61vxHK1FbQVFVdnblX2X K2yr/zViOG96uC5KD5xL6ZI5rb+WKXBq+CqfQOaFPBWOhD4xqi0BuLASGr5m5WIt yjUCA3MOGS1e7QT0lnv/ELUyiVRJkWmSy+4Yf4HrRROHcXnYPO0F4spJNqUEQzpZ PUBLGiM3Ce9mN+c5+dY38n4byUgGgAnSPrYbS3IsX8fa72mqVeyp3yuetuwlAyky bGl6r2nuFzoVhptxOcX9q3XxHEMWPRAV181vVG+AR9AbynizyF7/MZ12Y4TcxQK9 H578LJD/FV0vF2x/GpWiVVr5ECSLbym3Q97NN0QkoE3D7yc95MzQtpnlciQgy2yc zLT5C3R/tllhSjXFKT1O+IjUqiFN3SlQ8H5WV3oXoMtfF5rJOvLyUAPKj86PNpNw H+plVmOxXpCEhaDApLS6zQo44Xvw/TZ4Hy374kB1IK5sqfY0RAJqFBxAPc24FcWO xufy11Yca4WAZQEvMGl42H9TLMAjDgghyn25siu6td6aPVoffBA= =gzaD -----END PGP SIGNATURE----- --9UV9rz0O2dU/yYYn--