From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGxrn-0001W8-JI for guix-patches@gnu.org; Thu, 10 May 2018 22:33:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGxri-0000Au-Lp for guix-patches@gnu.org; Thu, 10 May 2018 22:33:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49106) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fGxri-0000Ag-H9 for guix-patches@gnu.org; Thu, 10 May 2018 22:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fGxri-0002z4-2c for guix-patches@gnu.org; Thu, 10 May 2018 22:33:02 -0400 Subject: [bug#31395] [PATCH 2/2] gnu: Add snap. Resent-Message-ID: Date: Thu, 10 May 2018 21:32:12 -0500 From: Eric Bavier Message-ID: <20180510213212.1bd91255@centurylink.net> In-Reply-To: <87efijpkng.fsf@nicolasgoaziou.fr> References: <20180509214622.28928-1-mail@nicolasgoaziou.fr> <20180509214622.28928-2-mail@nicolasgoaziou.fr> <20180509213625.5fa4db0a@centurylink.net> <87y3grpsgn.fsf@nicolasgoaziou.fr> <20180510084722.6df5e6b9@centurylink.net> <87efijpkng.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/.PCsr3kr/M59DMKk0+Qfa11"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nicolas Goaziou Cc: 31395@debbugs.gnu.org --Sig_/.PCsr3kr/M59DMKk0+Qfa11 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 10 May 2018 17:58:43 +0200 Nicolas Goaziou wrote: > Eric Bavier writes: >=20 > > It's worse than that. See e.g. > > https://marc.info/?l=3Dopenbsd-ports&m=3D151973450514279&w=3D2 > > > > Many other packages use it because the issue was only brought to light > > more recently. =20 >=20 > I see. Thank you for the reference. >=20 > > You don't need to use a git hash at all. If the release is tagged, you > > can use that in the git-reference commit. E.g. a recent package I > > made, "ghostwriter", does this. =20 >=20 > OK. I used `git-reference'. One difficulty I encountered is the working > directory when using `git-reference' is non-trivial. I though it would > put me in the cloned repository, but instead, it left me in an empty > directory, which is neither the source directory nor the output > directory. Maybe it should be documented in the manual. Maybe, yeah. The builders get dropped into the temporary build directory to start. >=20 > Also, note that I couldn't use (which "sh") or (which "xdg-open"), since > both returned #f. Probably a PATH problem, so I sticked to my previous > way of finding bash and xdg-open. Indeed, "which" looks in PATH, so what you've done is fine. >=20 > Here is the updated patch. Let me know what you think. >=20 LGTM! Thanks, `~Eric --Sig_/.PCsr3kr/M59DMKk0+Qfa11 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlr1AKwACgkQ/XPKxxnT JWYqBA//SQcfrTMqgACInV0N+DmGl8jBnb9k24dkoBBcc1yGi2isnLmk2kqUPaJP lz73k09lLw46FjXAW09HcaOk1izc7TKCPUEGJciSsfahrVO+L9TSmGifsvu1qdKn 4MDqI+11TrFDSNJtmn9VgPTi97gLvWz389M0C3cYo9UiRZv4y352JoWyU2DeyRby c4evDdukgHbTmRE+ENTLT4HmHbfVXBdgDP+m9Fgte0Ecu2HIK5vy8tcnfNdGTa4X InZI1LrXpCcjFhS3/Uf98GP8jqKrGSREYi3vOMTG9L0D3aRTEo6Sw0o5M6cF38T6 /RQtxbhILzYMUYYjeB8n985ZWoqQD3AyLoxPR4QL7HbDYg3pcW6ZebT/4oTzjVq1 QNFAsGPFeelKQOVsyiaM4uUtSH0VOwO1XfUwpKKEPQ20lz8LWccW/Meb90QGRevf teEGTgb4w26PHo/2FdeSMsJceniVR656aJKawu12b+eZoiQBAywzbk8UUQ8QiAM8 38R6MOVmFvCiJk7VyP5FiuTRZL8SgURxWCXiqT+7vyKLtAgCW3oqTJe2HOEalZPt jnyG8vWY/UeFSnRdKQtk2dF2DxEJVmWOOzOgYIIsfBXrpCg1fAAefJrOSMPFkaxa LDEBcJhhmINgcvp9G6uppd3sovoRHGkICc8zlNiA7uN+pNLTBnQ= =WqqT -----END PGP SIGNATURE----- --Sig_/.PCsr3kr/M59DMKk0+Qfa11--