From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fGW6A-0003px-4K
	for guix-patches@gnu.org; Wed, 09 May 2018 16:54:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fGW66-0000GG-6K
	for guix-patches@gnu.org; Wed, 09 May 2018 16:54:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47709)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fGW66-0000Fj-23
	for guix-patches@gnu.org; Wed, 09 May 2018 16:54:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fGW65-0007bj-KV
	for guix-patches@gnu.org; Wed, 09 May 2018 16:54:01 -0400
Subject: [bug#31393] [PATCH 0/4] Add android-fastboot and rename packages.
Resent-Message-ID: <handler.31393.B31393.152589921029204@debbugs.gnu.org>
Date: Wed, 9 May 2018 22:53:23 +0200
From: Julien Lepiller <julien@lepiller.eu>
Message-ID: <20180509225323.6678fe71@lepiller.eu>
In-Reply-To: <20180509203947.10746-1-dannym@scratchpost.org>
References: <20180509203947.10746-1-dannym@scratchpost.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 31393@debbugs.gnu.org



Le Wed,  9 May 2018 22:39:47 +0200,
Danny Milosavljevic <dannym@scratchpost.org> a =C3=A9crit :

> Danny Milosavljevic (4):
>   gnu: Add android-fastboot.
>   gnu: Rename "liblog" to "android-liblog".
>   gnu: Rename "libbase" to "android-libbase".
>   gnu: Rename "libcutils" to "android-libcutils".
>=20
>  gnu/packages/android.scm | 96
> ++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 80
> insertions(+), 16 deletions(-)

I haven't tested your patches, but if they work, LGTM!

Could you simply add a comment to explain why you don't run tests (I
guess there aren't any). Also, I'm not sure about the name of the
android-fastboot package. Since it provides the fastboot command, I
think the convention is to call it fastboot, like adb is not
android-adb.