From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45055)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fFllu-0005fE-Os
	for guix-patches@gnu.org; Mon, 07 May 2018 15:26:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fFllq-0004BR-Ox
	for guix-patches@gnu.org; Mon, 07 May 2018 15:26:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:45299)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fFllq-0004BN-L2
	for guix-patches@gnu.org; Mon, 07 May 2018 15:26:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fFllq-0001eQ-Cx
	for guix-patches@gnu.org; Mon, 07 May 2018 15:26:02 -0400
Subject: [bug#31333] [PATCH 01/22] gnu: Add groovy-java-bootstrap.
Resent-Message-ID: <handler.31333.B31333.15257211076287@debbugs.gnu.org>
Date: Mon, 7 May 2018 21:25:03 +0200
From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?=
	<bjoern.hoefling@bjoernhoefling.de>
Message-ID: <20180507212503.1683462a@alma-ubu>
In-Reply-To: <20180501154449.3531-1-julien@lepiller.eu>
References: <20180501174136.1c411b1a@lepiller.eu>
	<20180501154449.3531-1-julien@lepiller.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	boundary="Sig_/jl/zh/hm2joESX/yhEwWHzV";
	protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 31333@debbugs.gnu.org

--Sig_/jl/zh/hm2joESX/yhEwWHzV
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue,  1 May 2018 17:44:28 +0200
Julien Lepiller <julien@lepiller.eu> wrote:

[..]

> diff --git a/gnu/packages/groovy.scm b/gnu/packages/groovy.scm new
> file mode 100644 index 000000000..ee2894e30
> --- /dev/null
> +++ b/gnu/packages/groovy.scm

[..]

> +(define groovy-java-bootstrap
> +  (package
> +    (name "groovy-java-bootstrap")

I would suggest "java-groovy-bootstrap", because it is the
groovy-bootstrap, written in Java. Convention for programs in language
x is to prefix the name with "x-".


> +    (version "2.4.15")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> "https://github.com/apache/groovy/archive/GROOVY_"
> +                                  (string-map (lambda (x) (if (eq? x
> #\.) #\_ x)) version)
> +                                  ".tar.gz"))

Snippet missing:

              (snippet
               '(begin
                  (delete-file-recursively
              "gradle/wrapper/gradle-wrapper.jar") #t))

I tried it out, it still builds the whole series until groovy.


Otherwise, LGTM.

Bj=C3=B6rn

--Sig_/jl/zh/hm2joESX/yhEwWHzV
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlrwqBAACgkQvyhstlk+X/1rgwCgqsYn4Uk7omhe19ACZS0SGEbN
wugAoIuGRE888kPyxXKb6ru+SGqVqh4x
=vvma
-----END PGP SIGNATURE-----

--Sig_/jl/zh/hm2joESX/yhEwWHzV--