all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 31333@debbugs.gnu.org
Subject: [bug#31333] [PATCH 02/22] gnu: Add groovy-bootstrap.
Date: Sun, 6 May 2018 19:48:02 +0200	[thread overview]
Message-ID: <20180506194802.0ea9802e@scratchpost.org> (raw)
In-Reply-To: <20180501154449.3531-2-julien@lepiller.eu>

[-- Attachment #1: Type: text/plain, Size: 2236 bytes --]

Hi Julien,

> +         (add-before 'build 'fix-java8
> +           ;; Fix "Reference to plus is ambiguous"
> +           (lambda _
> +             (substitute* "src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java"
> +               (("toList\\(left\\)")
> +                "(List<T>)toList(left)"))))

#t

Also, is it possible to eventually upstream this fix?

> +         (add-before 'build 'generate-exception-utils
> +           (lambda _
> +             (system* "javac" "-cp" (getenv "CLASSPATH")
> +                      "config/ant/src/org/codehaus/groovy/ExceptionUtilsGenerator.java")

Hmm, is ignoring the exit status intentional?

> +             (zero? (system* "java" "-cp" (string-append (getenv "CLASSPATH")
> +                                                         ":config/ant/src")
> +                             "org.codehaus.groovy.ExceptionUtilsGenerator"
> +                             "target/classes/org/codehaus/groovy/runtime/ExceptionUtils.class"))))
> +         (add-before 'build 'generate-dgminfo
> +           (lambda _
> +             (mkdir-p "target/classes/org/codehaus/groovy/runtime")
> +             (mkdir-p "target/classes/META-INF")
> +             (system* "javac" "-cp" (getenv "CLASSPATH")
> +                      "src/main/org/codehaus/groovy/tools/DgmConverter.java")

Exit status ignored

> +             (zero? (system* "java" "-cp" (string-append (getenv "CLASSPATH")
> +                                                         ":src/main")
> +                             "org.codehaus.groovy.tools.DgmConverter"))))
> +         (add-before 'build 'copy-resources
> +           (lambda _
> +             (with-directory-excursion "src/main"
> +               (for-each (lambda (file)
> +                           (mkdir-p (string-append "../../target/classes/"
> +                                                   (dirname file)))
> +                           (copy-file file
> +                                      (string-append "../../target/classes/"
> +                                                     file)))
> +                  (find-files "." ".*.(txt|properties|xml|html)")))))

#t

Otherwise LGTM!


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-05-06 17:49 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 15:41 [bug#31333] [PATCH] Add groovy Julien Lepiller
2018-05-01 15:44 ` [bug#31333] [PATCH 01/22] gnu: Add groovy-java-bootstrap Julien Lepiller
2018-05-01 15:44   ` [bug#31333] [PATCH 02/22] gnu: Add groovy-bootstrap Julien Lepiller
2018-05-06 17:48     ` Danny Milosavljevic [this message]
2018-05-06 18:12       ` Julien Lepiller
2018-05-01 15:44   ` [bug#31333] [PATCH 03/22] gnu: Add groovy-tests-bootstrap Julien Lepiller
2018-05-07 18:01     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 04/22] gnu: Add groovy-test Julien Lepiller
2018-05-07 18:01     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 05/22] gnu: Add groovy-xml Julien Lepiller
2018-05-07 18:03     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 06/22] gnu: Add groovy-templates Julien Lepiller
2018-05-07 18:03     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 07/22] gnu: Add groovy-groovydoc Julien Lepiller
2018-05-07 18:04     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 08/22] gnu: Add groovy-ant Julien Lepiller
2018-05-07 18:05     ` Danny Milosavljevic
2018-05-07 19:04       ` Julien Lepiller
2018-05-01 15:44   ` [bug#31333] [PATCH 09/22] gnu: Add groovy-bsf Julien Lepiller
2018-05-07 18:07     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 10/22] gnu: Add groovy-swing Julien Lepiller
2018-05-07 18:09     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 11/22] gnu: Add groovy-console Julien Lepiller
2018-05-07 18:10     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 12/22] gnu: Add groovy-docgenerator Julien Lepiller
2018-05-07 18:10     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 13/22] gnu: Add groovy-groovysh Julien Lepiller
2018-05-07 18:11     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 14/22] gnu: Add groovy-jmx Julien Lepiller
2018-05-07 18:13     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 15/22] gnu: Add groovy-json Julien Lepiller
2018-05-07 18:13     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 16/22] gnu: Add groovy-jsr223 Julien Lepiller
2018-05-07 18:14     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 17/22] gnu: Add groovy-nio Julien Lepiller
2018-05-07 18:15     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 18/22] gnu: Add groovy-servlet Julien Lepiller
2018-05-07 18:15     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 19/22] gnu: Add groovy-sql Julien Lepiller
2018-05-07 18:16     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 20/22] gnu: Add groovy-testng Julien Lepiller
2018-05-07 18:16     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 21/22] gnu: Add groovy-macro Julien Lepiller
2018-05-07 18:17     ` Danny Milosavljevic
2018-05-01 15:44   ` [bug#31333] [PATCH 22/22] gnu: Add groovy Julien Lepiller
2018-05-07 19:23     ` Danny Milosavljevic
2018-05-07 17:58   ` [bug#31333] [PATCH 01/22] gnu: Add groovy-java-bootstrap Danny Milosavljevic
2018-05-07 19:25   ` Björn Höfling
2018-05-09 11:40 ` bug#31333: [PATCH] Add groovy Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180506194802.0ea9802e@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=31333@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.