From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDyP4-000101-7r for guix-patches@gnu.org; Wed, 02 May 2018 16:31:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDyP0-0000uK-HY for guix-patches@gnu.org; Wed, 02 May 2018 16:31:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39480) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDyP0-0000u3-BY for guix-patches@gnu.org; Wed, 02 May 2018 16:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fDyOz-0002Rf-NB for guix-patches@gnu.org; Wed, 02 May 2018 16:31:01 -0400 Subject: [bug#31331] [PATCH 1/2] gnu: Add bitlbee-discord. Resent-Message-ID: Date: Wed, 2 May 2018 20:30:51 +0000 From: Nils Gillmann Message-ID: <20180502203051.hdczlu5bc2wfgg6q@abyayala> References: <20180501120535.13961-1-contact@parouby.fr> <20180502184112.fi7dtxv2lzz3rxqi@abyayala> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: parouby Cc: 31331@debbugs.gnu.org, Nils Gillmann parouby transcribed 1.5K bytes: > Hi Nils, > > On 02/05/2018 20:41, Nils Gillmann wrote: > >> + (string-append > >> + "https://github.com/sm00th/bitlbee-discord/" > >> + "archive/" version ".tar.gz")) > > > > Nitpick, I would write it like:> + (uri > > + (string-append "https://github.com/sm00th/bitlbee-discord/" > > + "archive/" version ".tar.gz")) > > Yes, it's true, my bad ! > > >> + (add-before 'configure 'bash-path > >> + (lambda* (#:key inputs outputs #:allow-other-keys) > >> + (substitute* "configure" > >> + (("\\$SHELL") (string-append (assoc-ref inputs "bash") > >> + "/bin/sh"))))) > > > > Is the configure.ac in this case special, or why doesn't it pick our SHELL > > that is already in the environment of the build chroot? > > In this case, without modification the configure try to run '/bin/bash' > and don't care about 'SHELL' environment variable. > I don't found any other way. Any idea ? You could grep the guix source, folder gnu/packages, for cases where SHELL is set. Examples that come to my mind right now are in autotools.scm as well as gnuzilla.scm if I remember correctly. I would try setting the shell via environment variables or make/configure flags before patching in a file that I generated before. As a fallback that would be okay too, I think I did something similar to what you did in my Newmoon/Palemoon package. > >> + (native-inputs `(("pkg-config" ,pkg-config) > >> + ("autoconf" ,autoconf) > >> + ("automake" ,automake) > >> + ("texinfo" ,texinfo) > >> + ("libtool" ,libtool) > >> + ("bitlbee" ,bitlbee) > > > > Does the buildsystem of bitlbee-discord check for bitlbee, or why is this required? > > Yes it's need bitlbee lib and header for compilation (just like > bitlbee-dev debian package). I see. Okay. > Thanks, > -- > Pierre-Antoine