From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH] Create INDEX.LIST; Was: Fix references in jar manifests Date: Wed, 18 Apr 2018 15:25:43 +0200 Message-ID: <20180418152543.536a7462@scratchpost.org> References: <87zi3qfwfi.fsf@gnu.org> <20180320112855.33d86b6f@scratchpost.org> <6b4b40b375cc973d19a4ccfa14d011e1@lepiller.eu> <20180320131418.70989741@scratchpost.org> <20180321220731.4cfc7ea7@scratchpost.org> <20180325121918.4243938c@scratchpost.org> <87lge6y3s5.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/wLe4UjB_/0rLJIfYSkzDgKI"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8n5v-0001yt-Sg for guix-devel@gnu.org; Wed, 18 Apr 2018 09:26:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8n5q-0003aj-SZ for guix-devel@gnu.org; Wed, 18 Apr 2018 09:25:55 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:47322) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8n5q-0003ZN-LH for guix-devel@gnu.org; Wed, 18 Apr 2018 09:25:50 -0400 In-Reply-To: <87lge6y3s5.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Chris Marusich Cc: guix-devel@gnu.org --Sig_/wLe4UjB_/0rLJIfYSkzDgKI Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Chris, On Mon, 02 Apr 2018 00:12:42 +0200 Chris Marusich wrote: > Is that the only reason? My understanding is that we want to generate > the JAR indices not only (1) to ensure that grafting will work properly, > but also (2) to ensure that the reference scanner will find all the > store paths produced in the output JAR. Indeed. I'll update the comment. > > + (define (generate-index jar) > > + (invoke "jar" "-i" jar)) > > + (every (match-lambda > > + ((output . directory) > > + (every generate-index (find-files directory "\\.jar$")))) > > + outputs)) =20 >=20 > Does the jar program find the classes here via the CLASSPATH environment > variable, which was set earlier during the configure phase by the > generate-classpath procedure? I don't know. I assumed that it would unpack the jar file again and fiddle= with it in a mostly self-contained way as far as environment variables go. I'm trying to (setenv "CLASSPATH" #f) and am rebuilding the java packages n= ow... let's see... --Sig_/wLe4UjB_/0rLJIfYSkzDgKI Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlrXR1cACgkQ5xo1VCww uqWUXgf/XqoLekq4D5zq+UzguiYV4aJDY+7fB9Vt/DnvZ7TMJ5Ry0ujZPXc8dh/A f1GUGbW3//+lE7kMx32WKEf0rRftor2Ucu0yfWgqZ2HiXSGrnoqFYfS9JZJSpC2l T4FHklobhx2xZo1xpjNfHnXfiEZSwm0ZO7CyX6djFy+lPqgQdbQZc7iyoydexqaK 38UvXTzl62zsEpjS8/S8DX16rCVw0CEY6Bu0S8ziqnf1ujEmtTWue9L7OT/xH1c4 c7gR+CnEnDpvZ7IYrkPipQPk40Ppb46+rb2J7LMyBpp4f8EVWJqExuzkRAVLiH7b dn4gJlWQyLVso3ZICX/aTUAm2R9oUg== =Jufb -----END PGP SIGNATURE----- --Sig_/wLe4UjB_/0rLJIfYSkzDgKI--