From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8Z45-0004D0-Br for guix-patches@gnu.org; Tue, 17 Apr 2018 18:27:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8Z42-0005rQ-7A for guix-patches@gnu.org; Tue, 17 Apr 2018 18:27:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:50246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8Z42-0005qs-3p for guix-patches@gnu.org; Tue, 17 Apr 2018 18:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8Z41-0005Bk-Ne for guix-patches@gnu.org; Tue, 17 Apr 2018 18:27:01 -0400 Subject: [bug#31175] [PATCH] gnu: Add postgis. Resent-Message-ID: Date: Wed, 18 Apr 2018 00:26:45 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20180418002645.1626ef6b@alma-ubu> In-Reply-To: <20180416111821.48042726@lepiller.eu> References: <20180416111821.48042726@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/.lCdyd1qEF.G9N9F8.y17+L"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 31175@debbugs.gnu.org --Sig_/.lCdyd1qEF.G9N9F8.y17+L Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Julien, cool! Thanks for adding GDAL (and PostGIS). I have this on my TODO-list but haven't done it yet because of the long license list and all the dependencies. That's also the reason of why I haven't (yet?) done a full review. I only noticed two things: * Add a Copyright header for you. On Mon, 16 Apr 2018 11:18:21 +0200 Julien Lepiller wrote: > * gnu/packages/geo.scm (gdal): New variable. > --- > gnu/packages/geo.scm | 93 > ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 93 > insertions(+) [..] > + (home-page "http://www.gdal.org/") > + (synopsis "Raster and vector geospation data format library") This should be: geospatiAL=20 > + (description "GDAL is a translator library for raster and vector > geospatial +data formats. As a library, it presents a single raster > abstract data model +and single vector abstract data model to the > calling application for all +supported formats. It also comes with a > variety of useful command line +utilities for data translation and > processing.") OK. > + (license (list Not looked into this. Bj=C3=B6rn --Sig_/.lCdyd1qEF.G9N9F8.y17+L Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlrWdKYACgkQvyhstlk+X/3S8QCdHMvNOebrcLcNrJ6neZ1Xpb73 FG0AoIUXKs18DVHquuKu+ZRh8sARC0+X =Oa98 -----END PGP SIGNATURE----- --Sig_/.lCdyd1qEF.G9N9F8.y17+L--