all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: "Tomáš Čech" <sleep_walker@gnu.org>
Cc: 31174@debbugs.gnu.org
Subject: [bug#31174] [PATCH] gnu: Add go-golang-org-x-crypto-ssh-terminal.
Date: Tue, 17 Apr 2018 15:52:14 -0400	[thread overview]
Message-ID: <20180417195214.GA22258@jasmine.lan> (raw)
In-Reply-To: <20180416091120.15800-1-sleep_walker@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On Mon, Apr 16, 2018 at 11:11:20AM +0200, Tomáš Čech wrote:
> * gnu/packages/syncthing.scm (go-golang-org-x-crypto-ssh-terminal): New
> variable.

Thanks!

In general, LGTM.

Did you put this in the Syncthing module because that's where the
rest of the Go 'x' libraries live? If so, I'd rather move the full 'x'
suite to (gnu packages golang), since they are not specific to Syncthing
and are used by nearly every Go application. I can handle this move.

> +      (synopsis "TBD")
> +      (description "TBD")

This is the last missing bit :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-04-17 19:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-16  9:11 [bug#31174] [PATCH] gnu: Add go-golang-org-x-crypto-ssh-terminal Tomáš Čech
2018-04-17 19:52 ` Leo Famulari [this message]
2018-04-17 20:07   ` Tomáš Čech
2018-04-17 21:50     ` Leo Famulari
2018-04-19  8:05       ` Tomáš Čech
2018-04-19 14:40         ` Leo Famulari
2018-04-22 22:18           ` Tomáš Čech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180417195214.GA22258@jasmine.lan \
    --to=leo@famulari.name \
    --cc=31174@debbugs.gnu.org \
    --cc=sleep_walker@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.