From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8Bxn-000465-Gp for guix-patches@gnu.org; Mon, 16 Apr 2018 17:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8Bxm-0006si-H3 for guix-patches@gnu.org; Mon, 16 Apr 2018 17:47:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48428) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8Bxm-0006sV-Cv for guix-patches@gnu.org; Mon, 16 Apr 2018 17:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8Bxm-0007ys-5y for guix-patches@gnu.org; Mon, 16 Apr 2018 17:47:02 -0400 Subject: [bug#31121] [PATCH 1/3] gnu: Add python2-urlgrabber Resent-Message-ID: Date: Mon, 16 Apr 2018 23:46:32 +0200 From: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Message-ID: <20180416214632.w3hmsi6fmih3u6zr@doom> References: <20180410092425.5560-1-sleep_walker@gnu.org> <87y3hmde9z.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="szi4gvcxieq5n6hw" Content-Disposition: inline In-Reply-To: <87y3hmde9z.fsf@fastmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 31121@debbugs.gnu.org --szi4gvcxieq5n6hw Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Marius, On Mon, Apr 16, 2018 at 11:36:56PM +0200, Marius Bakke wrote: >Tom=C3=A1=C5=A1 =C4=8Cech writes: > >> * gnu/packages/python.scm (python2-urlgrabber): New variable. > >There is a 'python-web' module as well, would that be a good fit for >this package? python.scm had to be split up since it was causing >problems for the Guile compiler. I believe that it will fit into python-web as well. > >[...] > >> +(define-public python2-urlgrabber >> + (package >> + (name "python2-urlgrabber") >> + (version "3.10.2") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "urlgrabber" version)) >> + (sha256 >> + (base32 >> + "0w1h7hlsq406bxfy2pn4i9bd003bwl0q9b7p03z3g6yl0d21ddq5")))) >> + (build-system python-build-system) >> + (arguments >> + `(#:python ,python-2)) > >If Python 3 is unsupported, please add a comment about it. Otherwise >it's better to add a Python 3 variant and make the Py2 variant inherit >from it. Yes, python 2 is the only supported, I'll add comment. > >> + (home-page "http://urlgrabber.baseurl.org") >> + (synopsis "A high-level cross protocol url-grabber") > >Synopses should not start with an article (I believe `guix lint` will >warn about this). Simply "High-level cross-protocol URL grabber". I'll use that. > >> + (description "URL grabber library unifying http://, ftp:// and file= :// >> +protocols access, supporting HTTP keepalive, reget, throttling and other >> +convenience features.") > >Please turn this into one or more complete sentences. >E.g. "@code{urlgrabber} is a Python library that unifies access to >... It supports bla bla.". To be honest, this is always the most painful part for me. I'll try to come= with something better. > >> + (license license:lgpl2.1))) > >This should be LGPL2.1+ as mentioned in the code headers. I'll fix that. Thanks for review, I'll prepare next version. Best regards, S_W --szi4gvcxieq5n6hw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEDOrssfr9jDQthC2PSiPjT6AzQ20FAlrVGaoACgkQSiPjT6Az Q23epQ/+Pv7WN2Te0FvNW0YyDfDrF1LCF9lC/CLiEcwVBGUiXS/2zVInZpwsjpPr qVC+WtmH+FdNfg4i7+E/mOMty3wfmOTf/pHIlXwem+4iU3rhBkWhx1RTANx0gAW8 UUNZpVu/W4+aPbha7zgMIQkCFuufDlGkB7E9/3kdj20wFoIxP1xBj0VpCJuEy5fo QG3oGtiM+tNipjwK51I6lxeaQDQdCOr2fOoq1OFGz6VVuP3VOeAyCPMUaKFtVga/ WQEj53cKQMS0eN5AuqnhqguLn/YIBlxCuhLxa7w8YcJC1RAmuw0b0XiSzc36IJNM 438q8oKCMDNSUzOjsopS3HyEFWzxO3gfJLFDsR7eI3PSxAscuW4zeT3Vv5Gbdci8 JlXfkC27P/iFO46Q98FktOzuhW8sGrp+daa6WmwPs/+EFxQedYaG6l04LrIPlPhK ez/pujycjCQmA+I1WYR0F4KRcQbat7bHegm67k2rBHxGMNlGvF+JxHEa7np6HXbQ 5VL7l1CRE+Y6HKeF2QvjCfkEGJUKoOTq1Vb7leo1dKbgsj5pERutM/VVw2M3Pmzf VMMoNP9C9L4QOSfdRMnG/0u9gcrc4x0Cl/VDOCdrVm6pCqGyXyg2146FuZf/qqYr 8r8+ZVZ1j4aEfLqMpcqivmzc/41HdHYwz1QmUt386nufub0pM/Q= =rXN8 -----END PGP SIGNATURE----- --szi4gvcxieq5n6hw--