From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5qB9-0004Jf-TA for guix-patches@gnu.org; Tue, 10 Apr 2018 06:07:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5qB4-0003Ge-AD for guix-patches@gnu.org; Tue, 10 Apr 2018 06:07:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36700) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f5qB4-0003GA-5S for guix-patches@gnu.org; Tue, 10 Apr 2018 06:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f5qB3-0001vt-Vb for guix-patches@gnu.org; Tue, 10 Apr 2018 06:07:01 -0400 Subject: bug#31087: [PATCH] gnu: Add libcgroup. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Tue, 10 Apr 2018 12:05:59 +0200 From: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Message-ID: <20180410100559.GD23836@doom> References: <20180407112125.18650-1-sleep_walker@gnu.org> <20180407151724.11382-1-sleep_walker@gnu.org> <87o9isglsu.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eqp4TxRxnD4KrmFZ" Content-Disposition: inline In-Reply-To: <87o9isglsu.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31087-done@debbugs.gnu.org --eqp4TxRxnD4KrmFZ Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 09, 2018 at 10:35:45PM +0200, Ludovic Court=C3=A8s wrote: >Hello, > >Tom=C3=A1=C5=A1 =C4=8Cech skribis: > >> * gnu/packages/linux.scm (libcgroup): New variable. > >[...] > >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + ;; tests try to mount cgroup filesystem and fails because it s= eems it >> + ;; can't be mounted twice >> + ;; let's disable it >> + (delete 'check)))) > >Simply write #:tests? #f. > >> + (native-inputs >> + `(("bison" ,bison) >> + ("flex" ,flex) >> + ("linux-pam" ,linux-pam))) > >Should =E2=80=98linux-pam=E2=80=99 be in =E2=80=98inputs=E2=80=99 rather t= han =E2=80=98native-inputs=E2=80=99? > >Otherwise LGTM, thanks! Both things addressed, result pushed. Thanks for review! S_W --eqp4TxRxnD4KrmFZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEDOrssfr9jDQthC2PSiPjT6AzQ20FAlrMjIYACgkQSiPjT6Az Q215Ww/+K0Iggywxp0+745QOERZ4y5IV2RhNXJgV75hOfKTjtemnO+n74DGWc3xG QerhjSIvnAI0Gyj7gQy1nGztWqT0AhL03QaqdQ3uR8UVLps7SUYnC7fzqu/vigzh mPq9xUyoQ1G4mtxU7Y6QZUQBm3EOJ/1/YauRCPTwnfkY4xnsQYet5Zu46gPSH1cK 2QdNj/nKwn9+TboZACTbwCnjWNdm1Do6ymg5bRJE07J5+50DIbC61gpA8CrUijST 7d3Z/Zl93LW8bKP6oWj2J+6ncCpa0J/EAU8dsPZ5b8+8g/6u/jVCtKhW1MwAVefp CvX4Yhnd5mekdFBq88hQWd4D8JO0KfIpcIpwBC+ywqWK6fW8U4yfFi+aEl9S6LAZ yn/lBv7mz30yLcb2oM/7iJsT6F0WHtyltSzvxqu194GinIXmAuNwVpdfQnrgFCA5 4i4OIhhrkCmCKsP2AO5FMnqQ+Ba+ZxRQaoVmZqrOkwFzYVqy1KenO1WjoTuHhNah EODqHN6KZ2RJHL2cj8OHhgI13QlFlK2ljSMAb3SvmcnUf73TIXfSwECNOFBPeAPl Sm20qGKL7fYO/27VlsfPEa8MfrLRqvGM77VzDYRyBTO3wY/mGVRKYrcH9qSr5aG5 px6Aft6yYWFUdZ0V1Z/EOnkHnSLMWdREq0NKmCOkDNEtshyjkRQ= =LDlf -----END PGP SIGNATURE----- --eqp4TxRxnD4KrmFZ--