From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy) Date: Wed, 21 Mar 2018 10:35:49 +0200 Message-ID: <20180321083549.GA20703@macbook41> References: <87fu5pch36.fsf@elephly.net> <87h8pfy56s.fsf@elephly.net> <87tvtdthda.fsf@elephly.net> <87k1u8uccr.fsf@elephly.net> <87in9qdcws.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyZDv-00051F-Cp for guix-devel@gnu.org; Wed, 21 Mar 2018 04:35:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyZDs-000527-AO for guix-devel@gnu.org; Wed, 21 Mar 2018 04:35:55 -0400 Received: from flashner.co.il ([178.62.234.194]:51084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyZDr-00051W-W9 for guix-devel@gnu.org; Wed, 21 Mar 2018 04:35:52 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Vijayalakshmi Vedantham Cc: guix-devel@gnu.org --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 20, 2018 at 08:45:02PM +0530, Vijayalakshmi Vedantham wrote: > Hi, >=20 > I'm really sorry about the effort you had to put into this patch. I'll try > not to do it again. >=20 > I had to append =E2=80=9C.zip=E2=80=9D because Pypi didn=E2=80=99t have a= =E2=80=9C.tar.gz=E2=80=9D file for the > > sources, so the uri > > field now is: > > > > (pypi-uri "logwrap" version ".zip") > > >=20 > Did you do this because only .zip is available here ( > https://pypi.python.org/pypi/logwrap#downloads)? >=20 $ guix import pypi logwrap Starting download of /tmp/guix-file.BdwXcD =46rom https://pypi.python.org/packages/b3/17/c7d450ce6a1ce82e145852895509f= ddc9468225d2aa312a772bb9c188a73/logwrap-3.2.1.zip... =E2=80=A63.2.1.zip 241KiB 869KiB/s 00:00 [#############= #####] 100.0% In this case the importer grabbed a zip file, so I guess it falls into tribal knowledge, definately something that should be documented better. >=20 > > > > I also noticed that the sources include files that were generated with > > Cython. Instead of reusing those, we build them from source. Luckily > > all we have to do in this case is to add =E2=80=9Cpython-cython=E2=80= =9D to the > > native-inputs field. > > >=20 > Can I know how you knew this? For files that are generated by Cython they generally have a line at the top that reads: "Generated by Cython 0.x.y" or something along those lines. If you unzip the downloaded source and run 'grep Cython . -R' inside the folder it'll show any files generated by Cython. >=20 >=20 > > Finally, the tests. At first the tests wouldn=E2=80=99t run. So I look= ed up the > > error message online and found that I need to use =E2=80=9Cpython-pytes= t-runner=E2=80=9D > > in addition to =E2=80=9Cpython-pytest=E2=80=9D. This allows the tests = to run up to a > > point until it wants to do coverage tests. For those I needed to add > > =E2=80=9Cpython-pytest-cov=E2=80=9D. > > > > I changed the description, because I think it wasn=E2=80=99t quite corr= ect. > > >=20 > Again, I'm sorry. No worries, the test suite wasn't so easy. The release tarball/zip didn't include good directions for running the test suite, I had to go to the actual repository and see how the tests were run with 'tox' and then try recreating the commands; I wasn't successful. As far as the description goes, it's my least favorite part :). >=20 >=20 > Have you been able to build Guix already and try building the package > using =E2=80=9C./pre-inst-env guix build=E2=80=9D? >=20 > No, I tried last night but I faced some issues, I'll try again tonight. >=20 > Thanks, > Vijayalakshmi --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlqyGWIACgkQQarn3Mo9 g1FlJA/+JnvaBrsX6jgZ8qC1oCoMLsdfbup4mRN4iG+A6d5TErpjdti3+jXIA+6p dHhdbZ3UxveoTSl+Guk46Y3+PViKV3NkQ3ARVHzkkqxIblaZkqBruOi2zX3bNQfV DgDeIRtj+Gxhtd56uXF/evB6+uvCFEDxcbEBdjnSkhdkhyuoDPrqIKMsUSJHfE7r Lqm+9a/0LvSCm4CFNoVXjIr+mB6/kQu7VAmr2ZQvjtvioCosqu7YEc052KLlFbgL Ki8ShgVgvrZYYbMu1xO5gUr9yyzKjYkPtgnX2eC5uQAraJHPXVHXdGQJ3nknhLlm vF4hdUwHX0PSwQY6/VTufCo43fZIZoshZ6dPJ/ynKwIeSIFolDw5IlnZcRL6Yvva Lki/eovGZ/8NGB03i+0EHLTbtjLNM6OWQAZaGDP8JFLH1yGhDStvt3akbBO5aK3r 1GxeBsgOkMuw2kmZpD3/FpnwvD6PZLm1zFcozpYXKxauzwCr0jYeMcesFw8H715t 80KoBVPDFpqKldSNDXlwtqDsojsIYGKisJl/cadqOoP55TP9uwlCllFDgZxtEr2O 2XN96+Pna8iwUUOpv/w9eNjXAf2bRaVnBPcPd7K9z4FztiorQmKgscY/gAn6wu0+ lpljYx7UrCVczsylN5zqFmB/sgUhrQskHL4wuIUJeyfvX40qWOE= =sSrz -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/--