Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 2764 bytes --]

On Tue, Mar 20, 2018 at 08:45:02PM +0530, Vijayalakshmi Vedantham wrote:
> Hi,
> 
> I'm really sorry about the effort you had to put into this patch. I'll try
> not to do it again.
> 
> I had to append “.zip” because Pypi didn’t have a “.tar.gz” file for the
> > sources, so the uri
> > field now is:
> >
> >    (pypi-uri "logwrap" version ".zip")
> >
> 
> Did you do this because only .zip is available here (
> https://pypi.python.org/pypi/logwrap#downloads)?
> 

$ guix import pypi logwrap

Starting download of /tmp/guix-file.BdwXcD
From https://pypi.python.org/packages/b3/17/c7d450ce6a1ce82e145852895509fddc9468225d2aa312a772bb9c188a73/logwrap-3.2.1.zip...
 …3.2.1.zip  241KiB                   869KiB/s 00:00 [##################] 100.0%

In this case the importer grabbed a zip file, so I guess it falls into
tribal knowledge, definately something that should be documented better.

> 
> >
> > I also noticed that the sources include files that were generated with
> > Cython.  Instead of reusing those, we build them from source.  Luckily
> > all we have to do in this case is to add “python-cython” to the
> > native-inputs field.
> >
> 
> Can I know how you knew this?

For files that are generated by Cython they generally have a line at the
top that reads: "Generated by Cython 0.x.y" or something along those
lines. If you unzip the downloaded source and run 'grep Cython . -R'
inside the folder it'll show any files generated by Cython.

> 
> 
> > Finally, the tests. At first the tests wouldn’t run.  So I looked up the
> > error message online and found that I need to use “python-pytest-runner”
> > in addition to “python-pytest”.  This allows the tests to run up to a
> > point until it wants to do coverage tests.  For those I needed to add
> > “python-pytest-cov”.
> >
> > I changed the description, because I think it wasn’t quite correct.
> >
> 
> Again, I'm sorry.

No worries, the test suite wasn't so easy. The release tarball/zip
didn't include good directions for running the test suite, I had to go
to the actual repository and see how the tests were run with 'tox' and
then try recreating the commands; I wasn't successful.

As far as the description goes, it's my least favorite part :).

> 
> 
>      Have you been able to build Guix already and try building the package
> using “./pre-inst-env guix build”?
> 
> No, I tried last night but I faced some issues, I'll try again tonight.
> 
> Thanks,
> Vijayalakshmi

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]