From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= Subject: Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy) Date: Tue, 20 Mar 2018 19:34:34 +0100 Message-ID: <20180320193434.6ccc15ea@alma-ubu> References: <87fu5pch36.fsf@elephly.net> <87h8pfy56s.fsf@elephly.net> <87tvtdthda.fsf@elephly.net> <87k1u8uccr.fsf@elephly.net> <87in9qdcws.fsf@elephly.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/vi.Vy..4G8_v=cGk1o+auJ."; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyM5s-0007cF-RH for guix-devel@gnu.org; Tue, 20 Mar 2018 14:34:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyM5n-0005NK-Rg for guix-devel@gnu.org; Tue, 20 Mar 2018 14:34:44 -0400 Received: from m4s11.vlinux.de ([83.151.27.109]:50668 helo=bjoernhoefling.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyM5n-0005M8-JY for guix-devel@gnu.org; Tue, 20 Mar 2018 14:34:39 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Vijayalakshmi Vedantham Cc: guix-devel@gnu.org --Sig_/vi.Vy..4G8_v=cGk1o+auJ. Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Vijayalakshmi, welcome to Guix! On Tue, 20 Mar 2018 20:45:02 +0530 Vijayalakshmi Vedantham wrote: > Hi, >=20 > I'm really sorry about the effort you had to put into this patch. > I'll try not to do it again. Seriously: I hope you are not discouraged by that. And I hope you do it again and again. Including the errs. Guix is tough stuff and we all did and do our mistakes. And each one helps to understand the system a bit better. And I really like this community because it is so soft and helpful and polite :-) > > > > I also noticed that the sources include files that were generated > > with Cython. Instead of reusing those, we build them from source. > > Luckily all we have to do in this case is to add =E2=80=9Cpython-cython= =E2=80=9D to > > the native-inputs field. > > =20 >=20 > Can I know how you knew this? I can't speak for Ricardo but only for me: There is some intrinsic knowledge about each build system and each programming language, how they generate things, and how this relates to "building your software really from source in a FSF-compliant way". Just look at how others have done it in their package definitions. Present your package definition and get it reviewed. People will hint you politeful to this knowledge. > Have you been able to build Guix already and try building the > package using =E2=80=9C./pre-inst-env guix build=E2=80=9D? >=20 > No, I tried last night but I faced some issues, I'll try again > tonight. Before submitting a patch, try to build it at least twice. If you have trouble to build it, submit it anyway and tell why it doesn't build (twice, because of reproducibility). Take a look at the Manual at https://www.gnu.org/software/guix/manual/guix.html#Packaging-Guidelines and https://www.gnu.org/software/guix/manual/guix.html#Submitting-Patches The latter one is like a checklist to go through before submitting. Happy Guix-ing, Bj=C3=B6rn --Sig_/vi.Vy..4G8_v=cGk1o+auJ. Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlqxVDsACgkQvyhstlk+X/1EaACgpwBbB/yeLrTpMzuJ8FKGTLn1 BeQAn3Gh9oQIAhA3gXdVbX9Lhx9EUKw0 =xvmX -----END PGP SIGNATURE----- --Sig_/vi.Vy..4G8_v=cGk1o+auJ.--