all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Vijayalakshmi Vedantham <vijimay12@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Internship on Improve the user experience for the "guix package" command line tool (Outreachy)
Date: Tue, 20 Mar 2018 19:34:34 +0100	[thread overview]
Message-ID: <20180320193434.6ccc15ea@alma-ubu> (raw)
In-Reply-To: <CAD8c3_duj40tbxUkjvuKZvrEN126dV_g=RPMMntSKHoT83zqnA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]

Hi Vijayalakshmi,

welcome to Guix!


On Tue, 20 Mar 2018 20:45:02 +0530
Vijayalakshmi Vedantham <vijimay12@gmail.com> wrote:

> Hi,
> 
> I'm really sorry about the effort you had to put into this patch.
> I'll try not to do it again.

Seriously: I hope you are not discouraged by that. And I hope you do it
again and again. Including the errs. Guix is tough stuff and we all
did and do our mistakes. And each one helps to understand the system a
bit better.

And I really like this community because it is so soft and helpful
and polite :-)


> >
> > I also noticed that the sources include files that were generated
> > with Cython.  Instead of reusing those, we build them from source.
> > Luckily all we have to do in this case is to add “python-cython” to
> > the native-inputs field.
> >  
> 
> Can I know how you knew this?

I can't speak for Ricardo but only for me: There is some
intrinsic knowledge about each build system and each programming
language, how they generate things, and how this relates to "building
your software really from source in a FSF-compliant way".

Just look at how others have done it in their package definitions.
Present your package definition and get it reviewed. People will hint
you politeful to this knowledge.



>      Have you been able to build Guix already and try building the
> package using “./pre-inst-env guix build”?
> 
> No, I tried last night but I faced some issues, I'll try again
> tonight.

Before submitting a patch, try to build it at least twice. If you have
trouble to build it, submit it anyway and tell why it doesn't build
(twice, because of reproducibility).

Take a look at the Manual at

https://www.gnu.org/software/guix/manual/guix.html#Packaging-Guidelines

and


https://www.gnu.org/software/guix/manual/guix.html#Submitting-Patches

The latter one is like a checklist to go through before submitting.

Happy Guix-ing,

Björn



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2018-03-20 18:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAD8c3_e9+N2AEcR+fYs_bzsyLM9i85Fv1rT3P7jaPMKV+ihWog@mail.gmail.com>
     [not found] ` <CAD8c3_dj0sUOtb=kU4tCtLH1LesOQmkdSqDO+awvUFB8Q+8Q2A@mail.gmail.com>
     [not found]   ` <87fu5pch36.fsf@elephly.net>
     [not found]     ` <CAD8c3_c8hwg2pLdKvaPKyPzy+bgLVGekyF2vGVWFW-Fb-BX1ww@mail.gmail.com>
     [not found]       ` <87h8pfy56s.fsf@elephly.net>
     [not found]         ` <CAD8c3_foX-c-+j3jfkLHG1VcnL2u7s_ixj550XcU1Ch-Fbqtjg@mail.gmail.com>
     [not found]           ` <87tvtdthda.fsf@elephly.net>
     [not found]             ` <CAD8c3_fD241AogQiaQTo2g-vXcwrWjt9FhAejMh57ZB+cBmKKQ@mail.gmail.com>
     [not found]               ` <87k1u8uccr.fsf@elephly.net>
2018-03-19 16:58                 ` Internship on Improve the user experience for the "guix package" command line tool (Outreachy) Vijayalakshmi Vedantham
2018-03-19 20:27                   ` Ricardo Wurmus
2018-03-20 14:44                   ` Ricardo Wurmus
2018-03-20 15:15                     ` Vijayalakshmi Vedantham
2018-03-20 15:54                       ` Ricardo Wurmus
2018-03-20 18:34                       ` Björn Höfling [this message]
2018-03-21  8:35                       ` Efraim Flashner
2018-03-21 17:03                         ` Vijayalakshmi Vedantham
2018-03-21 19:44                           ` Gábor Boskovits

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180320193434.6ccc15ea@alma-ubu \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=guix-devel@gnu.org \
    --cc=vijimay12@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.