On Sun, 18 Mar 2018 14:05:29 +0100
Julien Lepiller <julien@lepiller.eu> wrote:

> * gnu/packages/java.scm (java-native-access): New variable.
> ---
>  gnu/packages/java.scm | 65
> +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed,
> 65 insertions(+)
> 
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 37eeda0a6..54b44a9d0 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -9547,3 +9547,68 @@ substitutions, splits, filtering filenames,
> etc.  This library is the successor of the OROMatcher, AwkTools,
> PerlTools, and TextTools libraries originally from ORO, Inc.")
>      (license license:asl2.0)))
> +
> +(define-public java-native-access
> +  (package
> +    (name "java-native-access")
> +    (version "4.5.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> "https://github.com/java-native-access/jna/"
> +                                  "archive/" version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "0zrpzkib6b905i018a9pqlzkqinphywr6y4jwv6mwp63jjqvqkd9"))
> +              (modules '((guix build utils)))
> +              (snippet
> +                `(for-each delete-file (find-files "." ".*.jar")))))

Additionaly snip away: natives/libffi: First it has a different license
(Expat) and second you have it already as a dependency.

There is a "dist" directory. Please look at at. It contains some
binaries.
Maybe strip it totally away, as it doesn't give us more than the source
we have?

./dist/jna.aar: Binary.

dist/src-full.zip contains two jars:
./lib/junit.jar
./lib/clover.jar

So, snip it away.

src-full.zip:./native/libffi/LICENSE:
Is EXPAT. Either snip away or add to license list.

Not completely digged into the "dist" directory.

[..]

> +    ;; Java Native Access project (JNA) is dual-licensed under 2
> +    ;; alternative Open Source/Free licenses: LGPL 2.1 or later and
> +    ;; Apache License 2.0. (starting with JNA version 4.0.0).
> +    (license (list
> +               license:asl2.0
> +               license:lgpl2.1+))))


Remove "Open Source/" from comment.


Otherwise, LGTM

Björn