From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exDig-0003oF-10 for guix-patches@gnu.org; Sat, 17 Mar 2018 11:26:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exDic-0001xJ-MD for guix-patches@gnu.org; Sat, 17 Mar 2018 11:26:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58922) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1exDic-0001x6-HH for guix-patches@gnu.org; Sat, 17 Mar 2018 11:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1exDic-0001Fj-8W for guix-patches@gnu.org; Sat, 17 Mar 2018 11:26:02 -0400 Subject: [bug#30259] [PATCH] gnu: octave: Add audio and Qt GUI support. Resent-Message-ID: Date: Sat, 17 Mar 2018 15:25:52 +0000 From: ng0 Message-ID: <20180317152552.eui5w7e275sx4ohu@abyayala> References: <20180126151311.9049-1-kkebreau@posteo.net> <87wp04fpjs.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> <87po5wfmui.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> <87372scat2.fsf@posteo.net> <877es3zmla.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> <87y3kjatrn.fsf@posteo.net> <87607mn846.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87607mn846.fsf@abyayala.i-did-not-set--mail-host-address--so-tickle-me> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 30259@debbugs.gnu.org ng0@n0.is transcribed 2.4K bytes: > On Sat, 27 Jan 2018, Kei Kebreau wrote: > > ng0+guixpatches@n0.is writes: > > > >> On Fri, 26 Jan 2018, Kei Kebreau wrote: > >>> ng0+guixpatches@n0.is writes: > >>> > >>>> On Fri, 26 Jan 2018, ng0+guixpatches@n0.is wrote: > >>>>> On Fri, 26 Jan 2018, Kei Kebreau wrote: > >>>>>> * gnu/packages/maths.scm (octave)[inputs]: Add qscintilla, qt, suitesparse, > >>>>>> libsndfile, portaudio and alsa-lib. > >>>>>> [native-inputs]: Add qttools. > >>>>>> [arguments]: Add 'patch-qscintilla-library-name' phase. > >>>>> > >>>>> Woo! Nice :) I've started work on the Qt GUI a while ago but > >>>>> never finished it. Do you think we should split this into octave > >>>>> and octave-qt (or octave-gui)? Qt is quiet huge and not everyone > >>>>> will want this I think. > >>>>> > >>>>> Building this now and getting back to you with results. > >>>>> > >> […] > >>>> Build, compiled, installed, LGTM and works for me. At least the > >>>> minimal basics I've tested. > >>>> > >>> > >>> Excellent! Thanks for testing this. > >>> > >>>> However I still think we should split it later on. I'm not sure > >>>> if other systems just provide it in one piece or if they provide > >>>> octave-cli, octave-qt, etc. > >>>> In my scenario we don't have substitutes for Qt all the time and > >>>> someone running a > >>>> machine which isn't capable of building Qt wants to use octave. > >>> > >>> I agree that this package should be split. Should a split be made now > >>> while we leave the lighter CLI-only Octave package available on master, > >>> or should it be postponed until later on? > >>> > >> > >> It could be done later on, but if you think it wouldn't be too > >> much work you could do it now. > > > > Done, I think! > > > >> Ideally this would leave 'octave' as it is and add > >> 'octave-whatever' ... octave-qt? Debian calls the package (with > >> just the Qt Gui) "qtoctave". octave-* should be reserved for > >> extensions (which we don't have right now), so maybe qtoctave > >> would fit into our naming scheme? > >> > >> > >> / I think I'm going to switch the subscribed address once more, > >> now that I have proper filtering I don't need the server-side > >> filtering. / > > > > Can you (and/or any bystanders reading this) test these? > > > > > > > > LGTM. > > qtoctave worked, the normal octave should be alright. > > Thank you very much for the work on this. Can someone push this? If nothing changed since the review I did, it's good to go and just catching digital dust. Patch still applies iirc as I build my active branch with it. -- A88C8ADD129828D7EAC02E52E22F9BBFEE348588 https://n0.is