From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewxPP-0000hX-MV for guix-patches@gnu.org; Fri, 16 Mar 2018 18:01:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewxPK-0007A3-RM for guix-patches@gnu.org; Fri, 16 Mar 2018 18:01:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewxPK-00079l-Ns for guix-patches@gnu.org; Fri, 16 Mar 2018 18:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewxPK-0003ZP-9y for guix-patches@gnu.org; Fri, 16 Mar 2018 18:01:02 -0400 Subject: [bug#30572] [PATCH 4/7] gnu: When building in a VM, share a temporary directory. Resent-Message-ID: Date: Fri, 16 Mar 2018 23:00:45 +0100 From: Danny Milosavljevic Message-ID: <20180316230045.63ad8439@scratchpost.org> In-Reply-To: <20180315040915.5556-5-cmmarusich@gmail.com> References: <20180222102933.4978-1-cmmarusich@gmail.com> <20180315040915.5556-1-cmmarusich@gmail.com> <20180315040915.5556-5-cmmarusich@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/S9pjeh7zlnSNEzYehTRh./F"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Chris Marusich Cc: bug#30572 <30572@debbugs.gnu.org> --Sig_/S9pjeh7zlnSNEzYehTRh./F Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable LGTM! There are now three manual "-virtfs" arguments to qemu. It's starting to i= rk me a little. It might make sense to generate those from %linux-vm-filesystems in order to not have so much duplication and places where things can go wro= ng when maintaining. If you'd like, could you maybe pass the %linux-vm-filesystems to load-in-linux-vm and then automatically calculate those -virtfs entries? (In a future patchset - I don't wanna hold up this one) There's already common-qemu-options which would support , and %store-mapping, so actually it would make sense to use those (probably = easiest to move build/vm.scm's load-in-linux-vm into system/vm.scm expression->derivation-in-linux-vm so the qemu stuff isn't scattered all ov= er the place - right now, half is in gnu/system/vm.scm and a mostly redundant = half is in gnu/build/vm.scm ... not ideal). There's a "mapping->file-system" helper, so it might make sense to use instead of in %linux-vm-filesystems. So all in all: * Modify %linux-vm-filesystems to be file-system-mappings instead of file-s= ystems. Also modify the place it is used. * Move load-in-linux-vm to gnu/system/vm.scm (maybe inline into caller). * Modify load-in-linux-vm to use common-qemu-options. Notice that the "-append" option is passed twice. Bug... <-- I just fixed = that in master If you want I can do it. --Sig_/S9pjeh7zlnSNEzYehTRh./F Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlqsPo0ACgkQ5xo1VCww uqWzggf9FMY4/5HtQlLiOJ3+eAb+KxPxCsnHLgY/s+NvC81IwnlhEg/M7vfx8dJ2 G2HN59cQMivFnGEAYeB0PmYsQOELaV8LEm9M2uiMVUarrO0Bi1825V8g+CRgiMgD IqfnFw7PvY8ye0gpq1PfmIIWHU24wMocuXdUItAqAJ6EOfYgo9O1vGSo/lZ7qDnB gKM2Dyp8MMe7gZMnmMoeGJoWQkxdWWxwyhp17d28sf/q3ukwMIxv0hJZYusl5TfB 7+vlOal8YQIwvNezuvRQiw8Gmu8yRxZryF432bwgej2v1MVOr1T1p33rkiliwnj1 t2IthTgBvK19COaaDZzVJIsfBo0aBg== =qcJX -----END PGP SIGNATURE----- --Sig_/S9pjeh7zlnSNEzYehTRh./F--