Shepherd release!

Shepherd release!

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hello Guix!

I’d like to release the Shepherd 0.3.3 within a couple of days if there
are no objections.

I’ll take a look at the remaining non-deterministic test failures
described at <https://bugs.gnu.org/30299> but I’d appreciate it if
people could give a hand by reproducing them and posting test-suite.log.
During development I never hit these.  :-/

For the record, it can be tested on GuixSD by running “make dist” in the
Shepherd and then applying a patch like this in Guix:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1237 bytes --]

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index ad31bc498..04cb69e1b 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -47,6 +47,7 @@
   #:use-module (guix build-system perl)
   #:use-module (guix build-system python)
   #:use-module (guix build-system trivial)
+  #:use-module (guix gexp)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
   #:use-module (gnu packages check)
@@ -159,16 +160,8 @@ and provides a \"top-like\" mode (monitoring).")
 (define-public shepherd
   (package
     (name "shepherd")
-    (version "0.3.2")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "ftp://alpha.gnu.org/gnu/dmd/shepherd-"
-                                  version ".tar.gz"))
-              (sha256
-               (base32
-                "174q1qg7yg6w1hfvlfv720hr6hid4h5xzw15y3ycfpspllzldhcb"))
-              (patches (search-patches "shepherd-close-fds.patch"
-                                       "shepherd-herd-status-sorted.patch"))))
+    (version "0.3.3")
+    (source (local-file "/data/src/shepherd/shepherd-0.3.2.tar.gz"))
     (build-system gnu-build-system)
     (arguments
      '(#:configure-flags '("--localstatedir=/var")))

[-- Attachment #3: Type: text/plain, Size: 87 bytes --]


From there you can run “make check-system” or ‘guix system vm’.

Ludo’.

Re: Shepherd release!

[Andreas Enge]

Hello!

On Fri, Mar 16, 2018 at 01:44:37PM +0100, Ludovic Courtès wrote:
> For the record, it can be tested on GuixSD by running “make dist” in the
> Shepherd and then applying a patch like this in Guix:

I am already failing in getting the shepherd configured. On a fresh git
checkout, I do
   autoreconf -vfi
and obtain the following:

autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
aclocal: warning: couldn't open directory 'm4': No such file or directory
autoreconf: configure.ac: tracing
autoreconf: configure.ac: AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION
autoreconf: configure.ac: not using Libtool
autoreconf: running: /gnu/store/lpic7aaifz4v2ih54sqgwn82p13zrjrh-autoconf-2.69/bin/autoconf --force
autoreconf: configure.ac: not using Autoheader
autoreconf: running: automake --add-missing --copy --force-missing
configure.ac:17: error: required file 'build-aux/config.rpath' not found
configure.ac:17: error: required file './ABOUT-NLS' not found
autoreconf: automake failed with exit status: 1

This happens with the most recent automake-1.16.1 from Guix, but also with
the previously installed 1.15.1.

To test my luck, I did a "touch" on these two files; then ./configure fails
with the following:

...
checking <sys/prctl.h> constants... done
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: error: cannot find input file: `po/Makefile.in.in'

Did I forget to execute anything else?

Andreas

Re: Shepherd release!

[David Pirotte]

[-- Attachment #1: Type: text/plain, Size: 2218 bytes --]

Hello,

Though I don't use neither contribute to shepherd, nor guix, guixsd either, I got
curious, because the error message did trigger a bell, so I went on and visited the
source code and here is my few cents :)

> I am already failing in getting the shepherd configured. On a fresh git
> checkout, I do
>    autoreconf -vfi
> and obtain the following:

I think it would be better if the tree had the traditional ./autogen.sh
or ./bootstrap, especially because it would contain more then just 'autoreconf -vfi'
(see below)

> autoreconf: Entering directory `.'
> autoreconf: configure.ac: not using Gettext
> autoreconf: running: aclocal --force -I m4
> aclocal: warning: couldn't open directory 'm4': No such file or directory

Not sure why this happens, I don't see the usual 'AC_CONFIG_MACRO_DIR([m4])'
in the shepherd configure.ac file, maybe someone else has a clue? It's a warning
though, so it might be ok anyway ...

> ...
> configure.ac:17: error: required file 'build-aux/config.rpath' not found
> configure.ac:17: error: required file './ABOUT-NLS' not found

Don't know about the later, but wrt the former, I started to get these errors soon
after I started to contribute to guile-gnome/guile-clutter, and here is what I wrote
in their respective ./autogen.sh

<---- autogen.sh starts here ---->
#!/bin/sh
# Run this to generate all the initial makefiles, etc.

# configure.ac uses the guile.m4 GUILE_FLAGS macro, among others,
# which needs build-aux/config.rpath which is not installed anymore by
# modern version of automake, and without it, this script will raise
# an error. For why it's needed, see the comments wtr in m4/guile.m4.
if [ ! -d "build-aux" ]; then
    mkdir build-aux
fi
touch build-aux/config.rpath

autoreconf -vif

echo
echo "Now run ./configure --prefix=/your/prefix."
<---- autogen.sh ends here ---->

> ...
> config.status: creating Makefile
> config.status: error: cannot find input file: `po/Makefile.in.in'
> ...

Here there are two problems:

1-	the configure.ac has a tipo

	line 86, it has '... po/Makefile.in'
	but it should be '... po/Makefile'

2-	the po subdir does not have a Makefile.in

HTH,
David

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Shepherd release!

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> autoreconf: running: automake --add-missing --copy --force-missing
> configure.ac:17: error: required file 'build-aux/config.rpath' not found
> configure.ac:17: error: required file './ABOUT-NLS' not found
> autoreconf: automake failed with exit status: 1

You probably need to run ‘gettextize’ first.

HTH!

Ludo’.

Re: Shepherd release!

[Andreas Enge]

On Mon, Mar 19, 2018 at 05:42:11PM +0100, Ludovic Courtès wrote:
> You probably need to run ‘gettextize’ first.

That is strange, why have I never heard about this command before?
Anyway, I tried, and it shows a lot of scary warnings:

...
Updating Makefile.am (backup is in Makefile.am~)
Updating configure.ac (backup is in configure.ac~)
Adding an entry to ChangeLog (backup is in ChangeLog~)

Please update po/Makevars so that it defines all the variables mentioned
in po/Makevars.template.
You can then remove po/Makevars.template.

Please run 'aclocal -I m4' to regenerate the aclocal.m4 file.
You need aclocal from GNU automake 1.9 (or newer) to do this.
Then run 'autoconf' to regenerate the configure file.

You might also want to copy the convenience header file gettext.h
from the /gnu/store/xd2ifxzy0wah00b4pj83djsqaw03793x-gettext-0.19.8.1/share/gettext directory into your package.
It is a wrapper around <libintl.h> that implements the configure --disable-nls
option.

Press Return to acknowledge the previous three paragraphs.


Then I just went ahead and did "autoreconf -vfi", but this yielded the
following error message:

autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
configure.ac:86: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES.
../../lib/autoconf/status.m4:288: AC_CONFIG_FILES is expanded from...
configure.ac:86: the top level
autom4te: /gnu/store/mqjjsvkvpbgp9ykmi9jcylzw44qk1hr4-m4-1.4.18/bin/m4 failed with exit status: 1
aclocal: error: echo failed with exit status: 1
autoreconf: aclocal failed with exit status: 1


Maybe I should follow the advice in the above "three paragraphs"?

$ aclocal -I m4
configure.ac:86: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES.
../../lib/autoconf/status.m4:288: AC_CONFIG_FILES is expanded from...
configure.ac:86: the top level
autom4te: /gnu/store/mqjjsvkvpbgp9ykmi9jcylzw44qk1hr4-m4-1.4.18/bin/m4 failed with exit status: 1
aclocal: error: echo failed with exit status: 1


This looks like the previous analysis by David Pirotte:

On Fri, Mar 16, 2018 at 11:47:24PM -0300, David Pirotte wrote:
> Here there are two problems:
>
> 1-    the configure.ac has a tipo
>
>       line 86, it has '... po/Makefile.in'
>       but it should be '... po/Makefile'
>
> 2-    the po subdir does not have a Makefile.in


Andreas

Re: Shepherd release!

[Ludovic Courtès]

Hello,

Andreas Enge <andreas@enge.fr> skribis:

> On Mon, Mar 19, 2018 at 05:42:11PM +0100, Ludovic Courtès wrote:
>> You probably need to run ‘gettextize’ first.
>
> That is strange, why have I never heard about this command before?

[...]

> Then I just went ahead and did "autoreconf -vfi", but this yielded the
> following error message:
>
> autoreconf: Entering directory `.'
> autoreconf: configure.ac: not using Gettext
> autoreconf: running: aclocal --force -I m4
> configure.ac:86: error: `po/Makefile.in' is already registered with AC_CONFIG_FILES.
> ../../lib/autoconf/status.m4:288: AC_CONFIG_FILES is expanded from...

That’s because gettextize added po/Makefile.in a second time in AC_CONFIG_FILES.

I don’t understand why ‘autoreconf’ doesn’t invoke ‘gettextize’ by
itself.  We’re doing the same as in Guix.

Other than that, it’s working as expected.  :-)

Ludo’.