From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evgE3-0001dG-Ko for guix-patches@gnu.org; Tue, 13 Mar 2018 05:28:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evgDy-0005QE-Ng for guix-patches@gnu.org; Tue, 13 Mar 2018 05:28:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:50177) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evgDy-0005Pn-Hp for guix-patches@gnu.org; Tue, 13 Mar 2018 05:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1evgDy-00067i-9z for guix-patches@gnu.org; Tue, 13 Mar 2018 05:28:02 -0400 Subject: [bug#30604] [PATCH v10 5/6] linux-initrd: Provide our own 'modprobe' program. Resent-Message-ID: Date: Tue, 13 Mar 2018 10:27:06 +0100 From: Danny Milosavljevic Message-ID: <20180313100539.442c4aa9@scratchpost.org> In-Reply-To: <87h8plkkkc.fsf@gnu.org> References: <87ina1qxic.fsf@gnu.org> <20180312123918.22645-1-ludo@gnu.org> <20180312123918.22645-5-ludo@gnu.org> <20180312210936.7f89a29c@scratchpost.org> <87h8plkkkc.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/sH6RIRsnItffXX8vE6x800c"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 30604@debbugs.gnu.org --Sig_/sH6RIRsnItffXX8vE6x800c Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Mon, 12 Mar 2018 23:14:59 +0100 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > > One of the devnames created statically is the one for btrfs, so not wri= ting or > > using devnames is not going to end well. =20 >=20 > We=E2=80=99re fine because btrfs, 9p, overlay, etc. all have an =E2=80=9C= fs-btrfs=E2=80=9D, > =E2=80=9Cfs-9p=E2=80=9D, etc. alias, which shows up in =E2=80=9Cmodules.a= lias=E2=80=9D. No need for > =E2=80=9Cmodules.devname=E2=80=9D AFAICS. The other filesystems are not such a problem - but BTRFS has its own snapsh= otting/ multivolume functionality - and it's possible that someone accesses /dev/bt= rfs-control "too early" for that. I applied your patches to a fresh clone of guix master now, ran the btrfs-r= oot-os system check, and indeed I get (tried two rounds, happened both times): $ make TESTS=3Dbtrfs-root-os check-system [...] Scanning for Btrfs filesystems WARNING: failed to open /dev/btrfs-control, skipping device registration: N= o suy ERROR: there are 1 errors while registering devices File system check on /dev/vda2 failed; spawning Bourne-like REPL GNU Guile 2.2.3 Copyright (C) 1995-2017 Free Software Foundation, Inc. Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'. This program is free software, and you are welcome to redistribute it under certain conditions; type `,show c' for details. Enter `,help' for help. (can't evaluate anything here) > > (I'd also copy the modules.builtin (from Linux). > > Also, what happens if we load a module which has as dependency a built= in? > > Will we try to load the builtin as a .ko file and fail the entire thin= g?) =20 >=20 > The dependency of a builtin is necessarily a builtin,=20 Yes. >and the kernel won=E2=80=99t invoke modprobe for a builtin, will it? =20 I've read Linux's __request_module and I can't find where they pre-check anything - neither whether there's already a builtin nor whether it's loaded already. They probably don't check. But I'll read it again, more carefully... (request_module isn't that popular so it makes sense for them not to compli= cate the kernel by these checks when there are like 8 callers in total - and all= on init) >Thanks for the insightful review! You're welcome :) --Sig_/sH6RIRsnItffXX8vE6x800c Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlqnmWoACgkQ5xo1VCww uqWYNQf+JldN8uxgw6yQsYw8jQ9KKV5ilkDItpc6iw+L5Sl3JsYovJ/ABc6JX5m6 nOuQHU4f1rjqJS5kqpFW/qOJbk+3tJSNfRuleJUdKjHfzp3qtTLLYOsN3fTF7OSI fqN2zqS0y5o/C/T1Ienr7Qx+oC6u56smD1FyoLELJDmL8vGj0qUjNytilqavqxwR cwtlGxaREEHmuIB2UjNCXUTUdgw5SDS8Dga/x53AvOEIBsc61Cjyd+j/jzoH3NYC g/reldxXWMPq/DlSkil2293jbnK11+5K/6do+bf5a7uoEdE8E5gKZFqrze7ZiwRS rfgNmo0u7rv146A2b1bNEw1XgZ9tPw== =fti+ -----END PGP SIGNATURE----- --Sig_/sH6RIRsnItffXX8vE6x800c--