From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34144)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1evTJh-0002s8-BX
	for guix-patches@gnu.org; Mon, 12 Mar 2018 15:41:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1evTJe-0000DE-7e
	for guix-patches@gnu.org; Mon, 12 Mar 2018 15:41:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49645)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1evTJe-0000D8-3t
	for guix-patches@gnu.org; Mon, 12 Mar 2018 15:41:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1evTJd-0001OO-Tx
	for guix-patches@gnu.org; Mon, 12 Mar 2018 15:41:01 -0400
Subject: [bug#30604] [PATCH v10 3/6] linux-modules: Add
	'load-needed-linux-modules'.
Resent-Message-ID: <handler.30604.B30604.15208836095264@debbugs.gnu.org>
Date: Mon, 12 Mar 2018 20:40:02 +0100
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20180312204002.09bfc72f@scratchpost.org>
In-Reply-To: <20180312123918.22645-3-ludo@gnu.org>
References: <87ina1qxic.fsf@gnu.org> <20180312123918.22645-1-ludo@gnu.org>
	<20180312123918.22645-3-ludo@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 30604@debbugs.gnu.org

> +        (let* ((alias   (string-trim-right
> +                         (call-with-input-file file get-string-all)))

Hmm... doesn't this trim other things than newline?

A quick internet search shows that most people do that.  Huh.

LGTM!