From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqnGA-0007En-Jk for guix-patches@gnu.org; Tue, 27 Feb 2018 16:58:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqnG7-0004u0-Is for guix-patches@gnu.org; Tue, 27 Feb 2018 16:58:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:56407) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqnG7-0004tk-DH for guix-patches@gnu.org; Tue, 27 Feb 2018 16:58:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eqnG7-0001g3-6d for guix-patches@gnu.org; Tue, 27 Feb 2018 16:58:03 -0500 Subject: [bug#28004] Chromium Resent-Message-ID: Date: Tue, 27 Feb 2018 21:57:17 +0000 From: ng0 Message-ID: <20180227215717.bie4f2zdrn5s5oyo@abyayala> References: <87wp0s2ewl.fsf@fastmail.com> <20180108232042.nqjurjr2bcfl2yyc@abyayala> <87373cey5b.fsf@fastmail.com> <87vag16g5z.fsf@gnu.org> <87fu75aar5.fsf@fastmail.com> <874lnkr0vf.fsf@gnu.org> <87vaejvclc.fsf@fastmail.com> <20180226200133.zsnahblbgzovrtmu@abyayala> <87muzvv7ku.fsf@fastmail.com> <20180226234144.032af030@alma-ubu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bwzlrzka7gfznhcm" Content-Disposition: inline In-Reply-To: <20180226234144.032af030@alma-ubu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 28004@debbugs.gnu.org --bwzlrzka7gfznhcm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Bj=C3=B6rn H=C3=B6fling transcribed 4.0K bytes: > Hi Marius, >=20 > On Mon, 26 Feb 2018 21:06:57 +0100 > Marius Bakke wrote: >=20 > > ng0 writes: > >=20 > > > Marius Bakke transcribed 2.1K bytes: =20 > > >> Mike Gerwitz writes: > > >> =20 > > >> > On Tue, Jan 16, 2018 at 20:01:34 +0100, Marius Bakke wrote: =20 > > >> >> If there are no objections, expect to see this in 'master' in > > >> >> 1-2 weeks. =20 > > >> > > > >> > I want to express gratitude for your hard work on this---given > > >> > that IceCat does not contain many of the FF devtool updates, > > >> > Chromium is very desirable for web development. It's also > > >> > needed for certain Node.js tools, like node-inspector. > > >> > > > >> > So, thank you! =20 > > >>=20 > > >> Thank *you* for the kind words! :-) > > >>=20 > > >> Here is the latest iteration of this patch. New in this version: > > >>=20 > > >> * Chromium 64 (duh). > > >> * The 'delete-bundled-software' phase has been moved to a snippet, > > >> shaving ~100MiB (~22%) off the compressed tarball size (and > > >> drastically reduces (de)compression time). > > >> * The New Tab page does not show any thumbnails for new profiles. = =20 > > > > > > I think you forgot to attach the patches :) =20 > >=20 > > Derp. I realized that and just used `git send-email`[0], but have > > attached it here for convenience since the debbugs web UI doesn't > > allow easy download of a raw message. > >=20 > > [0] https://debbugs.gnu.org/cgi/bugreport.cgi?msg=3D131;bug=3D28004#131 > >=20 >=20 >=20 > This looks like a lot of work. Thank you! >=20 > I quickly tried to apply and build the patch and have two first remarks: >=20 > The file says: >=20 > ;;; Copyright =C2=A9 2016, 2017, 2018 Marius Bakke >=20 > I haven't followed history, have you worked on this since 2016? Marius, myself (and others?) have been working on this at least since Octob= er 2017. I did a search, and indeed: Date: Tue, 27 Sep 2016 07:39:10 +0000 ... this = is when I first send the original Inox WIP. Wow. > One patch has a hash-mismatch: >=20 > Starting download of /gnu/store/q8hlws48cjfcmz6i40jrnxn3kp750gy4-chromium= -icu.patch > From https://anonscm.debian.org/cgit/pkg-chromium/pkg-chromium.git/plain/= debian/patches/system/icu.patch?id=3Ddebian/64.0.3282.119-2... > icu.patch 2KiB 1.8MiB/s 00:00 [####################]= 100.0% > output path `/gnu/store/q8hlws48cjfcmz6i40jrnxn3kp750gy4-chromium-icu.pat= ch' should have sha256 hash `0kf77d8lyma3w0xpgfv2k0c741zp6ii08gzllfja6d5s59= c15ylv', instead has `19r0bpv2hapzq5m0m7rlz1dwn3h2ijgkilb2hmhw56qvwpbw0b59' > @ build-failed /gnu/store/cqdllqn8ig5wnjn0yqvnh4vlzsvnpzv6-chromium-icu.p= atch.drv - 1 output path `/gnu/store/q8hlws48cjfcmz6i40jrnxn3kp750gy4-chrom= ium-icu.patch' should have sha256 hash `0kf77d8lyma3w0xpgfv2k0c741zp6ii08gz= llfja6d5s59c15ylv', instead has `19r0bpv2hapzq5m0m7rlz1dwn3h2ijgkilb2hmhw56= qvwpbw0b59' > cannot build derivation `/gnu/store/vacxbwsprcp52vp6q975450zi091dak2-chro= mium-64.0.3282.186.tar.xz.drv': 1 dependencies couldn't be built > @ build-started /gnu/store/7q53inn1v32b5fain0h0wcrliclf0ff1-libvpx+experi= mental-1.7.0.drv - x86_64-linux /var/log/guix/drvs/7q//53inn1v32b5fain0h0wc= rliclf0ff1-libvpx+experimental-1.7.0.drv.bz2 > cannot build derivation `/gnu/store/5qv7anaaqk4576pma9mhcsz1nhrx1n01-chro= mium-64.0.3282.186.drv': 1 dependencies couldn't be built > guix build: error: build failed: build of `/gnu/store/5qv7anaaqk4576pma9m= hcsz1nhrx1n01-chromium-64.0.3282.186.drv' failed >=20 > I looked into the file and it looks reasonable, like a patch-file. It has= no download errors. >=20 > It starts like this: >=20 > description: backwards compatibility for older versions of icu > author: Michael Gilbert >=20 > --- a/v8/src/runtime/runtime-intl.cc > +++ b/v8/src/runtime/runtime-intl.cc > @@ -627,7 +627,11 @@ RUNTIME_FUNCTION(Runtime_PluralRulesSele >=20 > ... >=20 > Can you check this file again? With the patch Marius send yesterday it works for me. > Bj=C3=B6rn >=20 >=20 --=20 A88C8ADD129828D7EAC02E52E22F9BBFEE348588 https://n0.is --bwzlrzka7gfznhcm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlqV1D0ACgkQ4i+bv+40 hYhqAQ//UY2/WT2moFhQDbhUIXhDTt/k+FmWuYcTbFJku1s6nYyPQDas90ctE1wH APbD7Zmv017EYCUIVSSiloboT1Q5EnNAHzgJwtcKCkRhVNpfTXaIG+vW6xXcbya0 bVcyKJ8KdjVrcOPlAopepI6uWuqSF6EL3LJG99iO6FySNDEDQ+20ZONXQX5g99UJ v7uSaFgc51OHu3LNaaT+1K1DC8CgwdekhTIr/dI1vfhh42Zz+HMVv7pm/8my4VlD KxUvaKRuNhU4SPbzWKSb9fKO0qfB2SysCMYpwPXkFCat2RALKNWxJfQj2ytTWIuN br80H7DwsWCtaUDcCG240JGX8+4cag/lwVBYK+w++5swbV+Li/TndPuJLDvUj1x4 v0xRu4IXC4vCZ3xLTMBjHLxARUxpcIobwSSUEirKliMAi6BXsNp4y/l4L/9TNlMN rIZYxosvPu3cZDPyJwnuAZuIAlBi0If+uKGht6GeThQKMpfktzvrdWfBEa+KQfjN nLHqu3tzrC7Z74h0su3DZpXrX2ftA1Zt8ixVszE4Bu47cfhjp3KahrGgsc/hfVXv KQxcYgCbW//gYJOjLmily/oR35X8nmQscXvdyp8KtTPQBWiCxWQZ+pia6TXw3/3c Klvd9263lF4zAmfM6sgWevzOQ+1zWikEm7IHmpsFr1lZRwz86MU= =ei6V -----END PGP SIGNATURE----- --bwzlrzka7gfznhcm--