From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45831)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eqSV5-0006jM-7k
	for guix-patches@gnu.org; Mon, 26 Feb 2018 18:48:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eqSV1-0005yR-9l
	for guix-patches@gnu.org; Mon, 26 Feb 2018 18:48:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:54445)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eqSV1-0005yL-5F
	for guix-patches@gnu.org; Mon, 26 Feb 2018 18:48:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eqSUz-0003zS-LT
	for guix-patches@gnu.org; Mon, 26 Feb 2018 18:48:02 -0500
Subject: [bug#30572] [PATCH 4/7] docker: Allow the use of a custom temporary
	directory.
Resent-Message-ID: <handler.30572.B30572.151968882915268@debbugs.gnu.org>
Date: Tue, 27 Feb 2018 00:46:58 +0100
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20180227004658.4cefda82@scratchpost.org>
In-Reply-To: <87po4rra78.fsf@garuda.local.i-did-not-set--mail-host-address--so-tickle-me>
References: <handler.30572.B.151929540925748.ack@debbugs.gnu.org>
	<20180222103528.5108-1-cmmarusich@gmail.com>
	<20180222103528.5108-4-cmmarusich@gmail.com>
	<20180226014859.4f7fe37c@scratchpost.org>
	<87po4rra78.fsf@garuda.local.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 30572@debbugs.gnu.org

Hi Chris,

On Mon, 26 Feb 2018 17:23:55 +0100
Chris Marusich <cmmarusich@gmail.com> wrote:

> Danny Milosavljevic <dannym@scratchpost.org> writes:
> 
> > Hmm, I have a slight preference for not magically adding "/docker-image" here
> > but rather adding it in the caller and in the default.
> 
> Good idea.  Here's a new version of Patch 4/7 which does what you
> suggest!  What do you think?

+         (and (zero? (apply system* "tar" "-C" tmpdir "-cf" image

Apparently this works as-is, but also here, I'd write

+         (and (zero? (apply system* "tar" "-cf" image "-C" tmpdir

Otherwise LGTM!