From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55544)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1epxuI-0006i7-2h
	for guix-patches@gnu.org; Sun, 25 Feb 2018 10:08:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1epxuE-0000go-UC
	for guix-patches@gnu.org; Sun, 25 Feb 2018 10:08:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:52638)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1epxuE-0000gI-Pu
	for guix-patches@gnu.org; Sun, 25 Feb 2018 10:08:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1epxuE-0001yi-Gh
	for guix-patches@gnu.org; Sun, 25 Feb 2018 10:08:02 -0500
Subject: [bug#30604] [PATCH 3/4] linux-initrd: Add kmod.
Resent-Message-ID: <handler.30604.B30604.15195712787594@debbugs.gnu.org>
Date: Sun, 25 Feb 2018 16:07:50 +0100
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20180225160750.46bf5b50@scratchpost.org>
In-Reply-To: <87vaelf9ln.fsf@gmail.com>
References: <20180225114557.816-1-dannym@scratchpost.org>
	<20180225114816.869-1-dannym@scratchpost.org>
	<20180225114816.869-3-dannym@scratchpost.org>
	<87vaelf9ln.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 30604@debbugs.gnu.org

Hi Mathieu,

thanks for the review.

On Sun, 25 Feb 2018 15:05:24 +0100
Mathieu Othacehe <m.othacehe@gmail.com> wrote:

> > +                  ; -E  
> 
> Why is this commented ?

Because it's an option for specifying the location of "Module.symvers" - and
I don't know whether guix uses it (probably not).  If one doesn't specify an
option, depmod will default to the running kernel - which is not what we want.

I should elaborate in the comment that, if we start using Module.symvers, we
MUST pass "-E" there.  Maybe better to even just check for the file existence
and add it right now, otherwise we might forget later.  What do you think?