From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoGmZ-0001pE-Jh for guix-patches@gnu.org; Tue, 20 Feb 2018 17:53:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoGmU-0002gh-Nu for guix-patches@gnu.org; Tue, 20 Feb 2018 17:53:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:45468) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eoGmU-0002gZ-Jr for guix-patches@gnu.org; Tue, 20 Feb 2018 17:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eoGmU-0006qb-CQ for guix-patches@gnu.org; Tue, 20 Feb 2018 17:53:02 -0500 Subject: [bug#30380] gnu: Add dolphin-emu. Resent-Message-ID: Date: Tue, 20 Feb 2018 23:52:08 +0100 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20180220235208.54ae3b81@alma-ubu> In-Reply-To: <20180216102046.562bda38@mykolab.com> References: <20180216102046.562bda38@mykolab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Rutger Helling Cc: 30380@debbugs.gnu.org Hi Rutger, On Fri, 16 Feb 2018 10:20:46 +0100 Rutger Helling wrote: > Hello everyone, >=20 > As promised I've updated these patches. Just to reiterate, these are > David's patches. I've only changed a few things. >=20 > Here's the changes of the top of my head: > * First patch is unchanged. > * Renamed to dolphin-emu instead of dolphin-emulator since that seems > like a more canonical name. > * Incorporated Bj=C3=B6rn's suggestions. > * Added a few more inputs to get rid of more externals. > * Enabled Qt interface. Thanks for taking another iteration of this.=20 In my review of the first patch by David I stated that I haven't done a full review. I just mentioned some points I noticed, not all possible critics. I still haven't done a full review and found some more points. As Dave said, this package bears some "friction": I'm still not convinced of it. For me this doesn't feel like a sound, perfect package. It is a collection of the emulators code plus binaries plus reverse-engineered codes and notes plus external documentation.=20 I thought of quickly fixing it myself but I find it hard to figure out what of the Data and the docs directory is really part of the program (documentation) and what can safely be stripped away. On the other hand there seams to be interest by at least 2-3 people to make a package out of that and I wouldn't say it's not possible. Here is what I found that should be stripped away: /review/dolphin-emu-5.0-0.d04b179-checkout$ find . -name "*.rar" -or -name "*.pdf" -or -name "*.bin" -or -name "*.pdf" -or -name "*.dsy" -or -na= me "*.jar" -or -name "*.exe"=20 ./docs/WiiMote/Dumps/WiiMote_AttribTree_0x10001.bin ./docs/WiiMote/Dumps/WiiMote_AttribTree_0x10000.bin ./docs/WiiMote/Dumps/WiiMote_AttribTree_0x10000_strip.bin ./docs/WiiMote/Dumps/WiiMote_AttribTree_0x10001_strip.bin ./docs/WiiMote/Dumps/WiiMote_ServiceScan.bin ./docs/WiiMote/HID_SPEC_V10.rar ./docs/DSP/GC_DSP.pdf ./Installer/vcredist/vc_redist.x64.exe ./Source/Android/code-style-java.jar ./Source/Android/gradle/wrapper/gradle-wrapper.jar ./Data/Sys/Wii/shared2/wc24/nwc24dl.bin ./Data/Sys/Wii/shared2/wc24/misc.bin ./Data/Sys/Wii/shared2/wc24/nwc24fls.bin ./Data/Sys/Wii/shared2/wc24/nwc24fl.bin ./Data/Sys/GC/font_western.bin ./Data/Sys/GC/font_japanese.bin ./Data/Sys/totaldb.dsy ./Data/Sys/codehandler.bin Yours, Bj=C3=B6rn