From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51269)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1enWb0-0006SI-BH
	for guix-patches@gnu.org; Sun, 18 Feb 2018 16:34:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1enWaw-0006R7-EE
	for guix-patches@gnu.org; Sun, 18 Feb 2018 16:34:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:42338)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1enWaw-0006Qy-B1
	for guix-patches@gnu.org; Sun, 18 Feb 2018 16:34:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1enWav-0005Jf-Vb
	for guix-patches@gnu.org; Sun, 18 Feb 2018 16:34:01 -0500
Subject: [bug#30492] [PATCH 3/4] gnu: Add wxwidgets@2.8.
Resent-Message-ID: <handler.30492.B30492.151898962820416@debbugs.gnu.org>
Date: Sun, 18 Feb 2018 22:33:44 +0100
From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?=
	<bjoern.hoefling@bjoernhoefling.de>
Message-ID: <20180218223344.5a7de7ca@alma-ubu>
In-Reply-To: <87efliteed.fsf@fastmail.com>
References: <20180216220913.08cc8ca0@alma-ubu>
	<20180216222004.0dfa956f@alma-ubu> <87efliteed.fsf@fastmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 30492@debbugs.gnu.org

On Sun, 18 Feb 2018 18:07:38 +0100
Marius Bakke <mbakke@fastmail.com> wrote:

> Bj=C3=B6rn H=C3=B6fling <bjoern.hoefling@bjoernhoefling.de> writes:
>=20
> > * gnu/packages/wxwidgets.scm (wxwidgets-2.8): New variable. =20
>=20
> This is effectively a revert of
> 6f9ba4c91c096a2fb95da111be0657d99ef2b683.  However, it does some
> things differently, can you have a look and see if this patch needs
> adjustment?
>=20
> [...]
>  =20
> > +(define-public wxwidgets-2.8
> > +  (package (inherit wxwidgets)
> > +           (version "2.8.12")
> > +           (source
> > +            (origin
> > +              (method url-fetch)
> > +              (uri (string-append
> > "https://github.com/wxWidgets/wxWidgets/archive/v"
> > +                                  version ".tar.gz")) =20
>=20
> wxWidgets provides "release" tarballs which are preferred to the
> auto-generated git archive tarballs.  See the above-mentioned commit
> for the proper URL :-)

Thanks Marius for reviewing that series.

I did not know that there was already a 2.8-version and haven't looked
into history. I copied the non-release URL from 3.1, which isn't
released yet :-)

I think I will just revert the commit you mentioned, as this worked
and was there in the past. How do I revert that, concerning the commit
message: Do I write a full, normal commmit like
"gnu/package/wxwidgets.scm: Add new variable"? Should I mention the
revert? Is it legitimate/necessary to add my copyright header,
although I haven't contributed any line?!

Thanks,

Bj=C3=B6rn