From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40451)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em4Cn-0002Fc-Oe
	for guix-patches@gnu.org; Wed, 14 Feb 2018 16:03:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em4Ck-0000pE-E9
	for guix-patches@gnu.org; Wed, 14 Feb 2018 16:03:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:35398)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1em4Ck-0000p8-AL
	for guix-patches@gnu.org; Wed, 14 Feb 2018 16:03:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em4Ck-00018Z-28
	for guix-patches@gnu.org; Wed, 14 Feb 2018 16:03:02 -0500
Subject: [bug#30417] [PATCH 11/11] gnu: Add java-plexus-sec-dispatcher.
Resent-Message-ID: <handler.30417.B30417.15186421524336@debbugs.gnu.org>
Date: Wed, 14 Feb 2018 22:02:28 +0100
From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?=
	<bjoern.hoefling@bjoernhoefling.de>
Message-ID: <20180214220228.7bd1f0a1@alma-ubu>
In-Reply-To: <20180214215919.401a5537@alma-ubu>
References: <20180210234811.40ddec07@lepiller.eu>
	<20180210230438.26794-11-julien@lepiller.eu>
	<20180214215919.401a5537@alma-ubu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 30417@debbugs.gnu.org

On Wed, 14 Feb 2018 21:59:19 +0100
Bj=C3=B6rn H=C3=B6fling <bjoern.hoefling@bjoernhoefling.de> wrote:

> On Sun, 11 Feb 2018 00:04:38 +0100
> Julien Lepiller <julien@lepiller.eu> wrote:
>=20
> > * gnu/packages/java.scm (java-plexus-sec-dispatcher): New variable.
> > ---
> >  gnu/packages/java.scm | 88
> > +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed,
> > 88 insertions(+)
> >=20
> > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> > index 758665df9..bd3fc7e70 100644
> > --- a/gnu/packages/java.scm
> > +++ b/gnu/packages/java.scm
> > @@ -2757,6 +2757,94 @@ compilers.")
> >      (description "This package contains the Javac Compiler support
> > for Plexus Compiler component.")))
> > =20
> > +(define-public java-plexus-sec-dispatcher
> > +  (package
> > +    (name "java-plexus-sec-dispatcher") =20
>=20
> [...]
>=20
> > +    (home-page "http://spice.sonatype.org/plexus-sec-dispatcher/")
> > +    (synopsis "Plexus Security Dispatcher Component")
> > +    (description "This package is the Plexus Security Dispatcher
> > Component. +This component descrypts a string passed to it") =20
>=20
> Spelling: s/descrypts/decrypts/
> Add a full-stop "." at the end of the last sentence.
>=20
> Otherwise, LGTM.
>=20
> Bj=C3=B6rn

Sorry, here is one more point:

The linter didn't complain about the homepage, but for me this is not
reachable. I would suggest:

https://github.com/sonatype/plexus-sec-dispatcher

Bj=C3=B6rn