From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33976)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em3li-0003Pt-5O
	for guix-patches@gnu.org; Wed, 14 Feb 2018 15:35:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em3ld-0007LH-UE
	for guix-patches@gnu.org; Wed, 14 Feb 2018 15:35:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:35356)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1em3ld-0007L6-QE
	for guix-patches@gnu.org; Wed, 14 Feb 2018 15:35:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em3ld-0000TK-KS
	for guix-patches@gnu.org; Wed, 14 Feb 2018 15:35:01 -0500
Subject: [bug#30417] [PATCH 07/11] gnu: Add java-modello-plugins-java.
Resent-Message-ID: <handler.30417.B30417.15186404471747@debbugs.gnu.org>
Date: Wed, 14 Feb 2018 21:34:02 +0100
From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?=
	<bjoern.hoefling@bjoernhoefling.de>
Message-ID: <20180214213402.35c33347@alma-ubu>
In-Reply-To: <20180210230438.26794-7-julien@lepiller.eu>
References: <20180210234811.40ddec07@lepiller.eu>
	<20180210230438.26794-7-julien@lepiller.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 30417@debbugs.gnu.org

On Sun, 11 Feb 2018 00:04:34 +0100
Julien Lepiller <julien@lepiller.eu> wrote:

> * gnu/packages/java.scm (java-modello-plugins-java): New variable.
> ---
>  gnu/packages/java.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>=20
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index d75960831..76a586a98 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2861,6 +2861,28 @@ single model, including Java POJOs,
> XML/JSON/YAML marshallers/unmarshallers, XSD and documentation.")
>      (license license:asl2.0)))
> =20
> +(define-public java-modello-plugins-java
> +  (package
> +    (inherit java-modello-core)
> +    (name "java-modello-plugins-java")
> +    (arguments
> +     `(#:jar-name "modello-plugins-java.jar"
> +       #:source-dir
> "modello-plugins/modello-plugin-java/src/main/java"
> +       #:test-dir "modello-plugins/modello-plugin-java/src/test"
> +       #:jdk ,icedtea-8
> +       #:tests? #f; requires maven-model, which depends on this
> package
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'copy-resources
> +           (lambda _
> +             (mkdir-p "build/classes")
> +             (copy-recursively
> "modello-plugins/modello-plugin-java/src/main/resources"
> +                               "build/classes")
> +             #t)))))
> +    (inputs
> +     `(("java-modello-core" ,java-modello-core)
> +       ,@(package-inputs java-modello-core)))))
> +
>  (define-public java-asm
>    (package
>      (name "java-asm")

License: This is again a mixture of ASL and "5-clause-BSD" like in
./modello-plugins/modello-plugin-java/src/main/java/org/codehaus/modello/pl=
ugin/java/javasource/JModifiers.java

Compare with comments in java-modello-core.

Synopsys and Description are inherited from java-modello-core but
should be specialized here.

Otherwise, LGTM.

Bj=C3=B6rn