From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1em4LW-0008KJ-1g for guix-patches@gnu.org; Wed, 14 Feb 2018 16:12:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1em4LT-0000As-Bn for guix-patches@gnu.org; Wed, 14 Feb 2018 16:12:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:35420) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1em4LT-0000An-3T for guix-patches@gnu.org; Wed, 14 Feb 2018 16:12:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1em4LS-0001M0-Ts for guix-patches@gnu.org; Wed, 14 Feb 2018 16:12:02 -0500 Subject: [bug#30456] [PATCH 1/2] gnu: Add mapnik. Resent-Message-ID: Date: Wed, 14 Feb 2018 16:11:05 -0500 From: Leo Famulari Message-ID: <20180214211105.GA22243@jasmine.lan> References: <20180214162903.23995-1-arunisaac@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn" Content-Disposition: inline In-Reply-To: <20180214162903.23995-1-arunisaac@systemreboot.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 30456@debbugs.gnu.org --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 14, 2018 at 09:59:03PM +0530, Arun Isaac wrote: > * gnu/packages/geo.scm (mapnik): New variable. Thanks! > + (version "3.0.16") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/mapnik/mapnik/releases/download/v" > + version "/mapnik-v" version ".tar.bz2")) I notice that 3.0.18 is available upstream. Please use that if possible, otherwise leave a code comment explaining why we use an older release. Otherwise LGTM --bp/iNruPH9dso1Pn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlqEpekACgkQJkb6MLrK fwiS5w/9GGdWvOn7xaDvyucCeVmP1B7l6sCspU0Kdfs5SMBun/J4WKVNZggcgX1P XmqN0mg39L0Hzok1zjNS3nqDU0yoUwK4yIObKrgXIoJxGoRl3ZpjxbBJDuGJWYRM FbBuoK6sQQctycSXh1Lp2Vd1EtOhaksR+ygsZHk1IjZ2FgyBmy154F8SpmwwjHul uxOLBLvAmNVw+j25ZZSYQVj2gerc8GJOBdf+Ryh0wtFk/E02G+XidTvxuM65Prxd qQsmZodVQLsv7NBIFHUW3OftC5TULTHtZOjUXwpy+i2s6D57D0g7CsJHBieSCNy9 bZ1OAwGRJsKkny/9ur2EOTN9T+ftXmSfF8OoFNvE4RWN299al+jmQ8Yc4qNEeyCg bWypRwEWJFFZ9+7v1YXgtCVYLw+G1ZdPQZDWrv1bKkQbAPpThZOfKyy8xnhj7BDJ i2IiA6LP0kTo3bZwclEydiz9okUqSv4hbZW9i2DVARSCvxNs71SHgzVQLQpswZml BYbPNGtwDhcvrdbPwe7xvWQaJ93wEBIPpEENe6YpVtuEZQJtuCSd51GHl31X41j0 gzUpjpPj/4dRd3kG6PMWIzK/SVUDoYTIVfgi7YJdCkuMVfk7NCjFjEA5eFo+urp9 0cM3ihwm/WACHfaDXCA4qUI7sIpjgNArj+2H+rx/0btLof351c4= =uvHW -----END PGP SIGNATURE----- --bp/iNruPH9dso1Pn--