From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48197)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em2ez-0004O5-CF
	for guix-patches@gnu.org; Wed, 14 Feb 2018 14:24:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em2ew-0000Py-4B
	for guix-patches@gnu.org; Wed, 14 Feb 2018 14:24:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:35290)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1em2ew-0000Ps-0I
	for guix-patches@gnu.org; Wed, 14 Feb 2018 14:24:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1em2ev-0005Kc-RX
	for guix-patches@gnu.org; Wed, 14 Feb 2018 14:24:01 -0500
Subject: [bug#30417] [PATCH 04/11] gnu: Add java-plexus-compiler-javac.
Resent-Message-ID: <handler.30417.B30417.151863619020437@debbugs.gnu.org>
Date: Wed, 14 Feb 2018 20:23:06 +0100
From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?=
	<bjoern.hoefling@bjoernhoefling.de>
Message-ID: <20180214202306.3645c832@alma-ubu>
In-Reply-To: <20180210230438.26794-4-julien@lepiller.eu>
References: <20180210234811.40ddec07@lepiller.eu>
	<20180210230438.26794-4-julien@lepiller.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 30417@debbugs.gnu.org

On Sun, 11 Feb 2018 00:04:31 +0100
Julien Lepiller <julien@lepiller.eu> wrote:

> gnu/packages/java.scm (java-plexus-compiler-javac): New variable.
> ---
>  gnu/packages/java.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>=20
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 55233b7ba..29439d667 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -2737,6 +2737,26 @@ and decryption.")
>  compilers.")
>      (license license:asl2.0)))
> =20
> +(define-public java-plexus-compiler-javac
> +  (package
> +    (inherit java-plexus-compiler-api)
> +    (name "java-plexus-compiler-javac")

LGTM, except of this comment:

This one also has some source files unde license:expat. As the package
inherits from java-plexus-compiler-api, and if you add the missing
license there, everything should be fine automatically.


Bj=C3=B6rn